Skip to content

DRAFT: Fixups for rust-server hyper1 support#2

Closed
dsteeley wants to merge 1 commit intomasterfrom
hyper1-bugfixes
Closed

DRAFT: Fixups for rust-server hyper1 support#2
dsteeley wants to merge 1 commit intomasterfrom
hyper1-bugfixes

Conversation

@dsteeley
Copy link
Copy Markdown
Owner

@dsteeley dsteeley commented Nov 10, 2025

Fixup minor bugs found in detailed testing of latest rust-server generator.

  1. Invalid variable names when using reserved terms.
  2. Invalid traits when field has no type specified.
  3. Mishandling of data types for application/gzip endpoints.
  4. Empty default field when a default isn't specified for enum types.

Fixed 1 by not using the r# prefixing when an endpoint matches a reserved name, this broke compilation as the sanitized name was used in the middle of variable names which was invalid syntax.
Fixed 2 by not appending the PartialOrd trait when the type was unspecified.
Fixed 3 by handling isBinary in various sections of the templates.
Fixed 4 by automatically generating default value from enum entry.

Tested on a variety of API documents for compilation, clippy and tests passing.

Fixed 4 for rust-server-deprecated so tests for that generator pass.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant