Skip to content

Commit 3ff7ca7

Browse files
committed
feat: render Github Markdown Tables in the text hover
commit 68f9534 added the necessary plugin for support for Github Markdown Tables but this library was not properly wired up. This commit correctly wires Github Markdown Tables support.
1 parent e2a2cdd commit 3ff7ca7

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

org.eclipse.lsp4e/META-INF/MANIFEST.MF

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ Require-Bundle: org.eclipse.core.runtime;bundle-version="3.12.0",
4141
org.eclipse.e4.core.commands,
4242
org.eclipse.compare.core,
4343
org.eclipse.compare,
44-
org.commonmark;bundle-version="0.23.0"
44+
org.commonmark;bundle-version="0.23.0",
45+
org.commonmark.ext-gfm-tables;bundle-version="0.23.0"
4546
Bundle-ClassPath: .
4647
Bundle-Localization: plugin
4748
Bundle-ActivationPolicy: lazy

org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/hover/LSPTextHover.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
import java.util.function.Predicate;
3030
import java.util.stream.Collectors;
3131

32+
import org.commonmark.Extension;
33+
import org.commonmark.ext.gfm.tables.TablesExtension;
3234
import org.commonmark.node.Node;
3335
import org.commonmark.parser.Parser;
3436
import org.commonmark.renderer.html.HtmlRenderer;
@@ -111,9 +113,10 @@ public class LSPTextHover implements ITextHover, ITextHoverExtension, ITextHover
111113
.collect(Collectors.joining("\n\n")) //$NON-NLS-1$
112114
.trim();
113115
if (!result.isEmpty()) {
114-
Parser parser = Parser.builder().build();
116+
List<Extension> extensions = List.of(TablesExtension.create());
117+
Parser parser = Parser.builder().extensions(extensions).build();
115118
Node document = parser.parse(result);
116-
HtmlRenderer renderer = HtmlRenderer.builder().build();
119+
HtmlRenderer renderer = HtmlRenderer.builder().extensions(extensions).build();
117120
return renderer.render(document);
118121
} else {
119122
return null;

0 commit comments

Comments
 (0)