fix: broken FilterInputStream in StreamConnectionProvider#forwardCopyTo#1352
Merged
mickaelistria merged 1 commit intoeclipse-lsp4e:mainfrom Oct 30, 2025
Merged
Conversation
sebthom
force-pushed
the
StreamConnectionProvider
branch
from
44ecffa to
e48fb3c
Compare
sebthom
force-pushed
the
StreamConnectionProvider
branch
from
e48fb3c to
aa6db97
Compare
Member
Author
|
@mickaelistria can you please have a look. you contributed the file initially and I would like your opinion on the hard coded |
Contributor
|
That's quite old code. I think it just happened to work in most cases and was never re-worked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StreamConnectionProvider#forwardCopyTo instantiates an anonymous FilterInputStream implementation with broken read method implementations (EOF handling). The
FilterInputStreamalso unnecessarily allocates new byte arrays on each array read operation. Additionally the single byte read method did not forward to the output stream but wrote the byte directly to stderr.