Skip to content

feat: adds Language Server ID column to LS tables in preference pages #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sebthom wants to merge 1 commit into from
Closed

feat: adds Language Server ID column to LS tables in preference pages #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/LanguageServerPreferencePage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,15 @@ public String getText(Object element) {
}
});

final var idConfigColumn = new TableViewerColumn(checkboxViewer, SWT.NONE);
idConfigColumn.getColumn().setText(Messages.PreferencesPage_languageServerId);
idConfigColumn.getColumn().setWidth(300);
idConfigColumn.setLabelProvider(new ColumnLabelProvider() {
@Override
public String getText(Object element) {
return ((ContentTypeToLanguageServerDefinition)element).getValue().id;
}
});

List<ContentTypeToLanguageServerDefinition> contentTypeToLanguageServerDefinitions = registry.getContentTypeToLSPExtensions();
if (contentTypeToLanguageServerDefinitions.stream()
Expand Down
11 changes: 11 additions & 0 deletions org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/LoggingPreferencePage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,17 @@ public String getText(Object element) {
}
});
addLoggingColumnsToViewer(languageServerViewer);

final var idConfigColumn = new TableViewerColumn(languageServerViewer, SWT.NONE);
idConfigColumn.getColumn().setText(Messages.PreferencesPage_languageServerId);
idConfigColumn.getColumn().setWidth(300);
idConfigColumn.setLabelProvider(new ColumnLabelProvider() {
@Override
public String getText(Object element) {
return ((ContentTypeToLanguageServerDefinition)element).getValue().id;
}
});

languageServerViewer.getControl().setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true));
languageServerViewer.getTable().setHeaderVisible(true);
languageServerViewer.getTable().setLinesVisible(true);
Expand Down
1 change: 1 addition & 0 deletions org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/Messages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public final class Messages extends NLS {
public static String PreferencesPage_Remove;
public static String PreferencesPage_contentType;
public static String PreferencesPage_languageServer;
public static String PreferencesPage_languageServerId;
public static String PreferencesPage_Enabled;
public static String PreferencesPage_enablementCondition;
public static String PreferencePage_enablementCondition_true;
Expand Down
1 change: 1 addition & 0 deletions org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ PreferencesPage_contentType=Content Type
PreferencesPage_Add=Add...
PreferencesPage_Remove=Remove
PreferencesPage_languageServer=Language Server
PreferencesPage_languageServerId=Language Server ID
PreferencesPage_Enabled=Enabled
PreferencesPage_enablementCondition=Enablement condition
PreferencePage_enablementCondition_true=\u2714\ufe0f
Expand Down