Skip to content

feat: add ID tooltip to Language Server columns in preference pages #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebthom merged 1 commit into from
Oct 30, 2025
Merged

feat: add ID tooltip to Language Server columns in preference pages #1359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/LanguageServerPreferencePage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import org.eclipse.jface.viewers.ArrayContentProvider;
import org.eclipse.jface.viewers.CheckboxTableViewer;
import org.eclipse.jface.viewers.ColumnLabelProvider;
import org.eclipse.jface.viewers.ColumnViewerToolTipSupport;
import org.eclipse.jface.viewers.ISelection;
import org.eclipse.jface.viewers.IStructuredSelection;
import org.eclipse.jface.viewers.TableViewer;
Expand Down Expand Up @@ -181,9 +182,10 @@ private void createStaticServersTable(Composite res) {
GridDataFactory.swtDefaults().align(SWT.FILL, SWT.TOP).grab(true, false).span(2, 1).hint(400, SWT.DEFAULT).applyTo(staticServersIntro);
staticServersIntro.setText(Messages.PreferencesPage_staticServers);
staticServersIntro.addSelectionListener(this.contentTypeLinkListener);
checkboxViewer = CheckboxTableViewer.newCheckList(res, SWT.NONE);
checkboxViewer = CheckboxTableViewer.newCheckList(res, SWT.FULL_SELECTION);
checkboxViewer.getControl().setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true));
checkboxViewer.setContentProvider(new ArrayContentProvider());
ColumnViewerToolTipSupport.enableFor(checkboxViewer);

final var enablementColumn = new TableViewerColumn(checkboxViewer, SWT.NONE);
enablementColumn.getColumn().setText(Messages.PreferencesPage_Enabled);
Expand Down Expand Up @@ -213,6 +215,11 @@ public String getText(Object element) {
public String getText(Object element) {
return ((ContentTypeToLanguageServerDefinition)element).getValue().label;
}

@Override
public String getToolTipText(Object element) {
return "ID: " + ((ContentTypeToLanguageServerDefinition) element).getValue().id; //$NON-NLS-1$
}
});


Expand Down
9 changes: 8 additions & 1 deletion org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/LoggingPreferencePage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,13 @@
import org.eclipse.jface.viewers.CellEditor;
import org.eclipse.jface.viewers.CheckboxCellEditor;
import org.eclipse.jface.viewers.ColumnLabelProvider;
import org.eclipse.jface.viewers.ColumnViewerToolTipSupport;
import org.eclipse.jface.viewers.EditingSupport;
import org.eclipse.jface.viewers.TableViewer;
import org.eclipse.jface.viewers.TableViewerColumn;
import org.eclipse.jface.wizard.WizardDialog;
import org.eclipse.jface.viewers.Viewer;
import org.eclipse.jface.viewers.ViewerComparator;
import org.eclipse.jface.wizard.WizardDialog;
import org.eclipse.lsp4e.ContentTypeToLSPLaunchConfigEntry;
import org.eclipse.lsp4e.ContentTypeToLanguageServerDefinition;
import org.eclipse.lsp4e.LanguageServerPlugin;
Expand Down Expand Up @@ -137,6 +138,7 @@ private void createStaticServersTable(Composite res) {
languageServerViewer = new TableViewer(res, SWT.FULL_SELECTION);
languageServerViewer.getControl().setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true));
languageServerViewer.setContentProvider(new ArrayContentProvider());
ColumnViewerToolTipSupport.enableFor(languageServerViewer);

final var launchConfigColumn = new TableViewerColumn(languageServerViewer, SWT.NONE);
launchConfigColumn.getColumn().setText(Messages.PreferencesPage_languageServer);
Expand All @@ -146,6 +148,11 @@ private void createStaticServersTable(Composite res) {
public String getText(Object element) {
return ((ContentTypeToLanguageServerDefinition) element).getValue().label;
}

@Override
public String getToolTipText(Object element) {
return "ID: " + ((ContentTypeToLanguageServerDefinition) element).getValue().id; //$NON-NLS-1$
}
});
addLoggingColumnsToViewer(languageServerViewer);

Expand Down