fix: Make sure DefaultFormatRegionsProvider is the default IFormatRegionsProvider#1363
Merged
rubenporras merged 1 commit intoeclipse-lsp4e:mainfrom Nov 6, 2025
Conversation
rubenporras
reviewed
Nov 5, 2025
FlorianKroiss
force-pushed
the
default-format-region-provider-ranking
branch
from
d4b77ab to
445c62b
Compare
…ionsProvider + Add `service.ranking=1` to the properties of DefaultFormatRegionsProvider, so that it is properly used as the default + Extract lookup for IFormatRegionsProvider into Utility class + Add test cases for lookup
rubenporras
force-pushed
the
default-format-region-provider-ranking
branch
from
445c62b to
cafd204
Compare
Contributor
|
@sebthom , the PR looks good to me. Since you participated in the Issue discussion, do you also agree we can merge this PR? If so I would merge it. |
Member
|
@rubenporras Fine with me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
service.ranking=1to the properties of DefaultFormatRegionsProvider, so that it is properly used as the default