feat: send LS error stream to Eclipse log.#1366
Merged
mickaelistria merged 1 commit intoeclipse-lsp4e:mainfrom Nov 7, 2025
Merged
feat: send LS error stream to Eclipse log.#1366mickaelistria merged 1 commit intoeclipse-lsp4e:mainfrom
mickaelistria merged 1 commit intoeclipse-lsp4e:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.gh.lumenfield.work/in/57789?s=60&v=4){kind=small}
andrewL-avlq
force-pushed
the
ProcessStdErr
branch
from
73ca1f1 to
22c4616
Compare
Forward lines written by the language server to std_err into the Eclipse log.
andrewL-avlq
force-pushed
the
ProcessStdErr
branch
from
22c4616 to
58b0433
Compare
Contributor
|
I think this is a good change, as otherwise we are not reading the standard error from the LS, and anything there is likely to just be lost. However, if someone has overriden the stream provider to read stderr, there will be two readers on stderr, which is not good. This work was initially part of cc2ba93 but I asked Andrew to split if off so that we have an independent decission. I would merge the PR and add a notice to the release notes. Do you agree? |
Contributor
Of course yes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward lines written by the language server to std_err into the Eclipse log.