fix: eliminate UI freezes in LSPTextHover via async updates#1375
Merged
sebthom merged 1 commit intoeclipse-lsp4e:mainfrom Nov 11, 2025
Merged
fix: eliminate UI freezes in LSPTextHover via async updates#1375sebthom merged 1 commit intoeclipse-lsp4e:mainfrom
sebthom merged 1 commit intoeclipse-lsp4e:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.gh.lumenfield.work/in/57789?s=60&v=4){kind=small}
rubenporras
reviewed
Nov 10, 2025
rubenporras
reviewed
Nov 10, 2025
Contributor
|
@sebthom , amazing PR, thanks a lot. This has been in my mind for a long time, but I never had time for it. |
sebthom
force-pushed
the
async-hovers
branch
from
5d52490 to
e9cc14b
Compare
rubenporras
reviewed
Nov 10, 2025
rubenporras
reviewed
Nov 10, 2025
rubenporras
reviewed
Nov 10, 2025
rubenporras
reviewed
Nov 10, 2025
sebthom
force-pushed
the
async-hovers
branch
2 times, most recently
from
9bb4427 to
f78f75e
Compare
rubenporras
reviewed
Nov 10, 2025
Contributor
|
@sebthom , I am finish with the review now. I am sorry that I did not have time to do the review all at once. |
LSPTextHover now implements ITextHoverExtension2 and returns an async input that shows a placeholder immediately and updates when the language server responds. The UI no longer waits for LS replies; getHoverRegion avoids blocking and falls back to a heuristic word-like region when data isn't ready. FocusableBrowserInformationControl swaps in the final HTML and hides/disposes the hover when the server returns no content, errors, or stalls, preventing lingering "Loading..." popups.
sebthom
force-pushed
the
async-hovers
branch
from
f78f75e to
afa10fb
Compare
rubenporras
approved these changes
Nov 11, 2025
This was referenced Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LSPTextHovernow implementsITextHoverExtension2and returns an async input that shows a placeholder immediately and updates when the language server responds.The UI no longer waits for LS replies; getHoverRegion avoids blocking and falls back to a heuristic word-like region when data isn't ready.
FocusableBrowserInformationControlswaps in the final HTML and hides/disposes the hover when the server returns no content, errors, or stalls, preventing lingering "Loading..." popups.Addresses #1270 #972