Skip to content

feat: prompt user when attempting to format a read-only file#1381

Merged
sebthom merged 1 commit intoeclipse-lsp4e:mainfrom
sebthom:issue-1078
Nov 13, 2025
Merged

feat: prompt user when attempting to format a read-only file#1381
sebthom merged 1 commit intoeclipse-lsp4e:mainfrom
sebthom:issue-1078

Conversation

@sebthom
Copy link
Copy Markdown
Member

@sebthom sebthom commented Nov 12, 2025

Implemented similar as in TM4E eclipse-tm4e/tm4e#896

Trying to format a read-only file displays a prompt to make the file writable.

image

Fixes #1078

Comment thread org.eclipse.lsp4e/src/org/eclipse/lsp4e/LSPEclipseUtils.java Fixed
@sebthom sebthom requested a review from rubenporras November 12, 2025 22:01
Comment thread org.eclipse.lsp4e/src/org/eclipse/lsp4e/DocumentContentSynchronizer.java Outdated
Comment thread org.eclipse.lsp4e/src/org/eclipse/lsp4e/DocumentContentSynchronizer.java Outdated
Comment thread org.eclipse.lsp4e/src/org/eclipse/lsp4e/LSPEclipseUtils.java Outdated
Copy link
Copy Markdown
Contributor

@rubenporras rubenporras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@sebthom sebthom merged commit a427ae3 into eclipse-lsp4e:main Nov 13, 2025
11 checks passed
@sebthom sebthom deleted the issue-1078 branch November 14, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LSP4E context menu Format action should not be allowed in read-only documents

3 participants