refactor: simplify DSPDebugModelPresentation#getText#1390
Merged
Conversation
Member
|
Couldn't someone extend DSPDebugTarget and also use an extended version of DSPStackFrame and may require to throw exceptions? I wonder if the throws declarations were added for a reason. |
Contributor
Author
|
I have not considered that, I will revert that removal |
by catching only checked exceptions and by combining dependent if branches into one.
rubenporras
force-pushed
the
refactor
branch
from
bcba944 to
549ce46
Compare
sebthom
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by catching only checked exceptions and by combining dependent if branches into one.