Skip to content

feat: Compare existing text case-insensitive when inserting completion without textedit#1392

Merged
rubenporras merged 1 commit intoeclipse-lsp4e:mainfrom
FlorianKroiss:case-insensitive
Nov 13, 2025
Merged

feat: Compare existing text case-insensitive when inserting completion without textedit#1392
rubenporras merged 1 commit intoeclipse-lsp4e:mainfrom
FlorianKroiss:case-insensitive

Conversation

@FlorianKroiss
Copy link
Copy Markdown
Contributor

Consider this piece of code:

MY_SUPER_DUPER_CONSTANT = 42

print(my_super|)

With | being the cursor, the server proposes a completion with MY_SUPER_DUPER_CONSTANT.
If we accept this proposal, we get the following result, because we compare the existing characters case-sensitive, when trying to figure out where to place the completion and what characters we can re-use:

print(my_superMY_SUPER_DUPER_CONSTANT)

With this PR, we do the comparison case-insensitive, which instead gives us:

print(MY_SUPER_DUPER_CONSTANT)

Note that this is only necessary for rudimentary completions which only have a label but no textedit.

@rubenporras rubenporras merged commit ba1c63a into eclipse-lsp4e:main Nov 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants