Supply proper information display string for completion proposal#1453
Merged
martinlippert merged 1 commit intoeclipse-lsp4e:mainfrom Dec 5, 2025
Merged
Supply proper information display string for completion proposal#1453martinlippert merged 1 commit intoeclipse-lsp4e:mainfrom
martinlippert merged 1 commit intoeclipse-lsp4e:mainfrom
Conversation
Signed-off-by: BoykoAlex <alex.boyko@broadcom.com>
BoykoAlex
force-pushed
the
fix-extra-line
branch
from
8fc5234 to
107af38
Compare
martinlippert
approved these changes
Dec 5, 2025
Contributor
martinlippert
left a comment
martinlippert
left a comment
There was a problem hiding this comment.
Looks good to me, content-assist in JDT is working fine again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1452
Previously the method was returning the result of
JavadocBrowserInformationControlInput#toString()which results in some erroneous behaviour leading to handling return key on the editor. Instead we should return proper string.Some polishing of the implementation around information control creation. It is safe to return additional info as string since information browser control accepts it.