Skip to content

fix: Restrict JUnit version#1466

Merged
rubenporras merged 1 commit intoeclipse-lsp4e:mainfrom
FlorianKroiss:restrict-junit-version
Dec 15, 2025
Merged

fix: Restrict JUnit version#1466
rubenporras merged 1 commit intoeclipse-lsp4e:mainfrom
FlorianKroiss:restrict-junit-version

Conversation

@FlorianKroiss
Copy link
Copy Markdown
Contributor

@FlorianKroiss FlorianKroiss commented Dec 14, 2025

This should fix the current problems with the maven build, i.e.,

Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:5.0.1:test (default-test) on project org.eclipse.lsp4e.test: No tests found

I restricted the JUnit Version to 5, which seems to be the fix, according to https://eclipse.dev/eclipse/markdown/?f=news/4.38/pde.md

@FlorianKroiss
Copy link
Copy Markdown
Contributor Author

Well, the tests are running again, be we seem to have a quite a few regressions and flaky tests :(

@rubenporras
Copy link
Copy Markdown
Contributor

Thanks for the PR, I will override the checks and merge it despite the build failures. I do not know what happened to the baseline and build artifacts check to report suddenly now different contents but same versions. Neither do I know what happened so that the test execution started to fail but this PR fixes at least this problem.

@rubenporras rubenporras marked this pull request as ready for review December 15, 2025 07:43
@rubenporras rubenporras merged commit 0ea70a2 into eclipse-lsp4e:main Dec 15, 2025
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants