Skip to content

fix: Handle Diagnostic with null severity #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenporras merged 1 commit into from
Jan 20, 2026
Merged

fix: Handle Diagnostic with null severity #1482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion org.eclipse.lsp4e/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: Language Server Protocol client for Eclipse IDE (Incubation)
Bundle-SymbolicName: org.eclipse.lsp4e;singleton:=true
Bundle-Version: 0.19.6.qualifier
Bundle-Version: 0.19.7.qualifier
Bundle-RequiredExecutionEnvironment: JavaSE-21
Require-Bundle: org.eclipse.core.runtime;bundle-version="3.12.0",
org.eclipse.equinox.common;bundle-version="3.8.0",
Expand Down
2 changes: 1 addition & 1 deletion org.eclipse.lsp4e/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</parent>
<artifactId>org.eclipse.lsp4e</artifactId>
<packaging>eclipse-plugin</packaging>
<version>0.19.6-SNAPSHOT</version>
<version>0.19.7-SNAPSHOT</version>

<build>
<plugins>
Expand Down
12 changes: 8 additions & 4 deletions org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/diagnostics/DiagnosticAnnotation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@

class DiagnosticAnnotation extends Annotation {

private static final String TYPE_INFO = "org.eclipse.ui.workbench.texteditor.info"; //$NON-NLS-1$
private static final String TYPE_WARNING = "org.eclipse.ui.workbench.texteditor.warning"; //$NON-NLS-1$
private static final String TYPE_ERROR = "org.eclipse.ui.workbench.texteditor.error"; //$NON-NLS-1$
private final Diagnostic diagnostic;
private final Function<Diagnostic, String> textComputer;

Expand All @@ -30,10 +33,11 @@ public DiagnosticAnnotation(Diagnostic diagnostic, Function<Diagnostic, String>
@Override
public String getType() {
return switch (diagnostic.getSeverity()) {
case Error -> "org.eclipse.ui.workbench.texteditor.error"; //$NON-NLS-1$
case Warning -> "org.eclipse.ui.workbench.texteditor.warning"; //$NON-NLS-1$
case Information -> "org.eclipse.ui.workbench.texteditor.info"; //$NON-NLS-1$
case Hint -> "org.eclipse.ui.workbench.texteditor.info"; //$NON-NLS-1$
case Error -> TYPE_ERROR;
case Warning -> TYPE_WARNING;
case Information -> TYPE_INFO;
case Hint -> TYPE_INFO;
case null -> TYPE_ERROR;
};
}

Expand Down