fix: Abort completion computations when encountering a BadLocationException#1486
Merged
rubenporras merged 1 commit intoJan 28, 2026
Merged
Conversation
FlorianKroiss
force-pushed
the
abort-on-badlocation
branch
from
18df5bb to
5e34f83
Compare
Contributor
Author
|
Draft for #1480 |
rubenporras
reviewed
Jan 26, 2026
Contributor
rubenporras
left a comment
rubenporras
left a comment
There was a problem hiding this comment.
Hi @FlorianKroiss ,
you have convinced me that it is the most pragmatic solution to ignore the BadLocationExceptions for the time being.
could you take a look at my comments?
FlorianKroiss
force-pushed
the
abort-on-badlocation
branch
2 times, most recently
from
6d2b310 to
c30715b
Compare
FlorianKroiss
force-pushed
the
abort-on-badlocation
branch
from
c30715b to
9d391c6
Compare
rubenporras
approved these changes
Jan 28, 2026
Contributor
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop computations when a
BadLocationExceptionhappens at certain points, because should only happen when the user modified the document while we were computing the completions. The changes made to the document make our completions invalid and thus they will be discarded anyway.Previously we would log the exception but I don't think that this is necessary.