Make overlay icons in various views like the outline view customizable in client plug-ins#1521
Conversation
- Extract method for determining all overlay icons so that clients can override it to customize overlay icons. - Introduce convenience method for determining a symbol's name. - Forward the symbol object to methods for calculating the symbol's icon and overlay icons so that clients could use additional symbol details for customization, e.g. name and details fields.
![github-advanced-security[bot]](https://avatars.gh.lumenfield.work/in/57789?s=60&v=4){kind=small}
|
Hi @rubenporras and @FlorianKroiss, |
| <attribute name="point" type="string" use="required"> | ||
| <annotation> | ||
| <documentation> | ||
|
|
There was a problem hiding this comment.
can you provide some documentation instead of the empty one?
There was a problem hiding this comment.
this applies to the other items as well
There was a problem hiding this comment.
I've extended the documentation. Is that what you had in mind?
| <meta.section type="since"/> | ||
| </appinfo> | ||
| <documentation> | ||
| [Enter the first release in which this extension point appears.] |
There was a problem hiding this comment.
I am not sure if we need all of these annotations documenting the extension point. If you can provide them, they are nice, but then we need meaningful tags.
There was a problem hiding this comment.
What do you mean by meaningful tags?
travkin79
force-pushed
the
patch-customizable-overlays
branch
from
5fe172b to
44962f2
Compare
travkin79
force-pushed
the
patch-customizable-overlays
branch
from
8a124c8 to
44da61b
Compare
|
Hi @rubenporras and @FlorianKroiss, It would be great if we could create a new LSP4E release with that change soon, since my related CDT LSP PR eclipse-cdt/cdt-lsp#609 depends on this PR. |
|
there is a new release |
|
Thank you very much, @rubenporras and @FlorianKroiss! You're feedback is very welcome and always helpful. Thank you also for quickly releasing the changes @rubenporras. 👍 |
4 participants
This PR makes overlay icon calculation customizable in client plug-ins (e.g. in CDT LSP) by introducing a new extension point for custom
SymbolIcenProviderimplementations. CustomSymbolIcenProviders are registered for certain content types and are used in all views / dialogs like outline view, call hierarchy, and type hierachy.An exemplary customization (introducing a custom overlay icon for destructors) is implemented in CDT LSP PR eclipse-cdt/cdt-lsp#609, see corresponding issue eclipse-cdt/cdt-lsp#608.