Skip to content

Log server Info messages only if TRACE is enabled. #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raghucssit wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Log server Info messages only if TRACE is enabled. #1523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion org.eclipse.lsp4e/src/org/eclipse/lsp4e/ServerMessageHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,12 @@ public static void logMessage(LanguageServerWrapper wrapper, MessageParams param
case Warning:
LanguageServerPlugin.logWarning(log.toString());
break;
case Info:
default:
LanguageServerPlugin.logInfo(log.toString());
if (LanguageServerPlugin.isLogTraceEnabled()) {
LanguageServerPlugin.logInfo(log.toString());
}
Comment on lines +92 to +94
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now gates INFO (and the default branch) behind LanguageServerPlugin.isLogTraceEnabled() (debug option org.eclipse.lsp4e/trace). The shipped org.eclipse.lsp4e/.options currently only declares org.eclipse.lsp4e/debug, so the trace option isn’t discoverable when launching with -debug. Consider adding/documenting org.eclipse.lsp4e/trace in the plugin’s .options (and/or user-facing docs) so users can actually enable these logs when needed.

Copilot uses AI. Check for mistakes.
break;
}
}

Expand Down
Loading