build: Support a wider range of Eclipse versions#1526
Draft
FlorianKroiss wants to merge 1 commit intoeclipse-lsp4e:mainfrom
Draft
build: Support a wider range of Eclipse versions#1526FlorianKroiss wants to merge 1 commit intoeclipse-lsp4e:mainfrom
FlorianKroiss wants to merge 1 commit intoeclipse-lsp4e:mainfrom
Conversation
FlorianKroiss
changed the title
![github-advanced-security[bot]](https://avatars.gh.lumenfield.work/in/57789?s=60&v=4){kind=small}
| // Fall-through | ||
| } | ||
| } | ||
| viewer.setSorter(new CommonViewerSorter()); |
FlorianKroiss
force-pushed
the
support-older-eclipse-targets
branch
from
53c25ef to
e0cbc54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, we now have three Target Platforms:
This replaces the workaround for the
CommonViewerSorterintroduced in #1516, since we now compile against an Eclipse Version, where onlyCommonViewerSorterexists and we have to check forCommonViewerComparatorvia reflection.This also rolls back the Upgrade to JUnit 6. This isn't really a problem, because we only use API that also exists in JUnit 5.
Fixes #1525