Fix path parsing on Windows in SymbolIconProviderRegistry & add tests#1532
Open
travkin79 wants to merge 1 commit intoeclipse-lsp4e:mainfrom
Open
Fix path parsing on Windows in SymbolIconProviderRegistry & add tests#1532travkin79 wants to merge 1 commit intoeclipse-lsp4e:mainfrom
travkin79 wants to merge 1 commit intoeclipse-lsp4e:mainfrom
Conversation
travkin79
changed the title
FlorianKroiss
requested changes
Apr 27, 2026
travkin79
changed the title
FlorianKroiss
approved these changes
Apr 29, 2026
- Add test case for reproducing a windows path parsing issue - Move helper method to utility class - Fix path parsing: Path.of(uri.getPath()) => Path.of(uri) - Bump test plug-in version
travkin79
force-pushed
the
patch-add-icon-provider-test
branch
from
973e19c to
b2f851e
Compare
Contributor
Author
|
Thank you @FlorianKroiss for your review. Hello @rubenporras, do you think, we could merge now? I squashed and rebased my PR commits. Oh, I see, the license check fails, but I don't see the reason. Any suggestions? Besides, I'm wondering about some of our tests sporadically failing for strange reasons. Are there any ideas how we could avoid that? |
FlorianKroiss
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows a path parsing issue can occur while retrieving overlay icons for the outline view, type hierarchy, or call hierarchy. This PR provides a fix for an issue reported in CDT LSP and adds a test for reproducing that issue.