Paint circular dirty indicator in editor list popups#3963
Open
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Open
Paint circular dirty indicator in editor list popups#3963vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
The Ctrl+E editor switcher and the tab chevron drop-down kept showing the legacy '*' prefix even when the new tab dirty-indicator style was enabled. They now paint the same filled 8 px circle next to the title that CTabFolderRenderer.drawDirtyIndicator draws on tabs, so the visual style stays consistent with the tabs the user is switching between. The drawing lives in a shared DirtyIndicatorPainter so the two popups, and any future list views that want the same style, call into one place. When the preference is off, the legacy '*' prefix is unchanged. Closes eclipse-platform#3960
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ctrl+E editor switcher and the tab chevron drop-down kept showing the legacy
*prefix even when the new tab dirty-indicator style was enabled, which #3960 reported. They now paint the same filled 8 px circle next to the title thatCTabFolderRenderer.drawDirtyIndicatordraws on tabs, so the visual style stays consistent with the tabs the user is switching between.The drawing lives in a shared
DirtyIndicatorPainterso the two popups, and any future list views that want the same style, call into one place. When the preference is off, the legacy*prefix is unchanged.Closes #3960