Skip to content

Match SourceViewer canvas background to text widget #3965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vogella wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −0
Draft

Match SourceViewer canvas background to text widget #3965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/SourceViewer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import org.eclipse.swt.SWT;
import org.eclipse.swt.custom.StyleRange;
import org.eclipse.swt.custom.StyledText;
import org.eclipse.swt.graphics.Color;
import org.eclipse.swt.graphics.Point;
import org.eclipse.swt.graphics.Rectangle;
import org.eclipse.swt.widgets.Canvas;
Expand Down Expand Up @@ -468,6 +469,25 @@ protected void createControl(Composite parent, int styles) {
if (fOverviewRuler != null) {
fOverviewRuler.createControl(fComposite, this);
}

if (fComposite != null) {
StyledText textWidget= getTextWidget();
if (textWidget != null) {
// Match the canvas background to the text widget so the RulerLayout gap blends in.
syncCompositeBackground(textWidget);
textWidget.addPaintListener(e -> syncCompositeBackground(textWidget));
}
}
}

private void syncCompositeBackground(StyledText textWidget) {
if (fComposite == null || fComposite.isDisposed() || textWidget.isDisposed()) {
return;
}
Color desired= textWidget.getBackground();
if (desired != null && !desired.equals(fComposite.getBackground())) {
fComposite.setBackground(desired);
}
}

/**
Expand Down
Loading