Feature/no descriptor fallback#84
Merged
mjheilmann merged 12 commits intomainfrom May 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds a
descriptor/0synthesizer, to start supporting the reflection of grpc services where protos were compiled without descriptor support. Ifdescriptor/0is not present, we automatically try to synthesize and continue.The compiled elixir code has enough info to service, encode, and decode messages, so it should know enough to tell another service about it through reflection. This is leveraging that known knowledge (via internal structures)
This has a lot of tests, and test services - regenerating most test services without descriptors for testing. When
descriptor/0is preset behavior should be un-changed, so this is opt-in functionality.