Remove legacy Hermes C++ code and HERMES_V1_ENABLED compile definition (#56731)#56731
Open
cipolleschi wants to merge 1 commit intofacebook:mainfrom
Open
Remove legacy Hermes C++ code and HERMES_V1_ENABLED compile definition (#56731)#56731cipolleschi wants to merge 1 commit intofacebook:mainfrom
cipolleschi wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104228879. |
cortinico
approved these changes
May 8, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
facebook#56731) Summary: - Remove all dead C++ code behind `!defined(HERMES_V1_ENABLED)` guards in `HermesExecutorFactory.cpp` and `HermesInstance.cpp` - Delete `Registration.h`, `Registration.cpp`, `ConnectionDemux.h`, `ConnectionDemux.cpp`, and `ConnectionDemuxTests.cpp` (entirely legacy code) - Remove `HERMES_V1_ENABLED` compile definition from `react-native-flags.cmake` - Remove `HERMES_V1_ENABLED` cache variable from Android `CMakeLists.txt` This is Phase 1 of removing legacy Hermes support. Since Hermes V1 is already the default on all platforms and the 0.86 branch has been cut, all legacy Hermes code is dead and can be safely removed. ## Changelog: [General][Breaking] - Remove Legacy Hermes from C++ code ## Test plan - [x] Android: `./gradlew :packages:rn-tester:android:app:assembleDebug` — BUILD SUCCEEDED - [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED Reviewed By: cortinico Differential Revision: D104228879
meta-codesync
Bot
changed the title
cipolleschi
force-pushed
the
export-D104228879
branch
from
69d2c50 to
ff90cda
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
May 8, 2026
#56731) Summary: - Remove all dead C++ code behind `!defined(HERMES_V1_ENABLED)` guards in `HermesExecutorFactory.cpp` and `HermesInstance.cpp` - Delete `Registration.h`, `Registration.cpp`, `ConnectionDemux.h`, `ConnectionDemux.cpp`, and `ConnectionDemuxTests.cpp` (entirely legacy code) - Remove `HERMES_V1_ENABLED` compile definition from `react-native-flags.cmake` - Remove `HERMES_V1_ENABLED` cache variable from Android `CMakeLists.txt` This is Phase 1 of removing legacy Hermes support. Since Hermes V1 is already the default on all platforms and the 0.86 branch has been cut, all legacy Hermes code is dead and can be safely removed. ## Changelog: [General][Breaking] - Remove Legacy Hermes from C++ code ## Test plan - [x] Android: `./gradlew :packages:rn-tester:android:app:assembleDebug` — BUILD SUCCEEDED - [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED Reviewed By: cortinico Differential Revision: D104228879
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 8, 2026
facebook#56731) Summary: - Remove all dead C++ code behind `!defined(HERMES_V1_ENABLED)` guards in `HermesExecutorFactory.cpp` and `HermesInstance.cpp` - Delete `Registration.h`, `Registration.cpp`, `ConnectionDemux.h`, `ConnectionDemux.cpp`, and `ConnectionDemuxTests.cpp` (entirely legacy code) - Remove `HERMES_V1_ENABLED` compile definition from `react-native-flags.cmake` - Remove `HERMES_V1_ENABLED` cache variable from Android `CMakeLists.txt` This is Phase 1 of removing legacy Hermes support. Since Hermes V1 is already the default on all platforms and the 0.86 branch has been cut, all legacy Hermes code is dead and can be safely removed. ## Changelog: [General][Breaking] - Remove Legacy Hermes from C++ code ## Test plan - [x] Android: `./gradlew :packages:rn-tester:android:app:assembleDebug` — BUILD SUCCEEDED - [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED Reviewed By: cortinico Differential Revision: D104228879
meta-codesync Bot
pushed a commit
that referenced
this pull request
May 8, 2026
#56731) Summary: - Remove all dead C++ code behind `!defined(HERMES_V1_ENABLED)` guards in `HermesExecutorFactory.cpp` and `HermesInstance.cpp` - Delete `Registration.h`, `Registration.cpp`, `ConnectionDemux.h`, `ConnectionDemux.cpp`, and `ConnectionDemuxTests.cpp` (entirely legacy code) - Remove `HERMES_V1_ENABLED` compile definition from `react-native-flags.cmake` - Remove `HERMES_V1_ENABLED` cache variable from Android `CMakeLists.txt` This is Phase 1 of removing legacy Hermes support. Since Hermes V1 is already the default on all platforms and the 0.86 branch has been cut, all legacy Hermes code is dead and can be safely removed. ## Changelog: [General][Breaking] - Remove Legacy Hermes from C++ code ## Test plan - [x] Android: `./gradlew :packages:rn-tester:android:app:assembleDebug` — BUILD SUCCEEDED - [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED Reviewed By: cortinico Differential Revision: D104228879
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
!defined(HERMES_V1_ENABLED)guards inHermesExecutorFactory.cppandHermesInstance.cppRegistration.h,Registration.cpp,ConnectionDemux.h,ConnectionDemux.cpp, andConnectionDemuxTests.cpp(entirely legacy code)HERMES_V1_ENABLEDcompile definition fromreact-native-flags.cmakeHERMES_V1_ENABLEDcache variable from AndroidCMakeLists.txtThis is Phase 1 of removing legacy Hermes support. Since Hermes V1 is already the default on all platforms and the 0.86 branch has been cut, all legacy Hermes code
is dead and can be safely removed.
Changelog:
[General][Breaking] - Remove Legacy Hermes from C++ code
Test plan
./gradlew :packages:rn-tester:android:app:assembleDebug— BUILD SUCCEEDEDxcodebuildrn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDEDReviewed By: cortinico
Differential Revision: D104228879