Remove RCT_HERMES_V1_ENABLED from CocoaPods infrastructure (#56735)#56735
Open
cipolleschi wants to merge 3 commits intomainfrom
Open
Remove RCT_HERMES_V1_ENABLED from CocoaPods infrastructure (#56735)#56735cipolleschi wants to merge 3 commits intomainfrom
cipolleschi wants to merge 3 commits intomainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104247277. |
cortinico
approved these changes
May 8, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync
Bot
changed the title
meta-codesync Bot
pushed a commit
that referenced
this pull request
May 8, 2026
Summary:
- Remove `RCT_HERMES_V1_ENABLED` environment variable from `react_native_pods.rb`
- Simplify `jsengine.rb` to always use `.hermesversion` tag file
- Remove conditional `HERMES_V1_ENABLED=1` preprocessor definition from `utils.rb`
- Simplify `hermes-engine.podspec`: always read `HERMES_VERSION_NAME`, use V1 source files, remove legacy inspector subspecs
- Simplify `hermes-utils.rb`: remove `hermes_v1_enabled()` function, always use `250829098.0.0-stable` branch, always use `.hermesversion` tag file
## Changelog:
[iOS][Removed] - Remove the RCT_HERMES_V1_ENABLED from Cocoapods
## Test plan
- [x] iOS: `bundle exec pod install` — success
- [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED
Reviewed By: cortinico
Differential Revision: D104247277
meta-codesync
Bot
force-pushed
the
export-D104247277
branch
2 times, most recently
from
000b428 to
e0db644
Compare
meta-codesync Bot
pushed a commit
that referenced
this pull request
May 8, 2026
Summary:
- Remove `RCT_HERMES_V1_ENABLED` environment variable from `react_native_pods.rb`
- Simplify `jsengine.rb` to always use `.hermesversion` tag file
- Remove conditional `HERMES_V1_ENABLED=1` preprocessor definition from `utils.rb`
- Simplify `hermes-engine.podspec`: always read `HERMES_VERSION_NAME`, use V1 source files, remove legacy inspector subspecs
- Simplify `hermes-utils.rb`: remove `hermes_v1_enabled()` function, always use `250829098.0.0-stable` branch, always use `.hermesversion` tag file
## Changelog:
[iOS][Removed] - Remove the RCT_HERMES_V1_ENABLED from Cocoapods
## Test plan
- [x] iOS: `bundle exec pod install` — success
- [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED
Reviewed By: cortinico
Differential Revision: D104247277
#56731) Summary: - Remove all dead C++ code behind `!defined(HERMES_V1_ENABLED)` guards in `HermesExecutorFactory.cpp` and `HermesInstance.cpp` - Delete `Registration.h`, `Registration.cpp`, `ConnectionDemux.h`, `ConnectionDemux.cpp`, and `ConnectionDemuxTests.cpp` (entirely legacy code) - Remove `HERMES_V1_ENABLED` compile definition from `react-native-flags.cmake` - Remove `HERMES_V1_ENABLED` cache variable from Android `CMakeLists.txt` This is Phase 1 of removing legacy Hermes support. Since Hermes V1 is already the default on all platforms and the 0.86 branch has been cut, all legacy Hermes code is dead and can be safely removed. ## Changelog: [General][Breaking] - Remove Legacy Hermes from C++ code ## Test plan - [x] Android: `./gradlew :packages:rn-tester:android:app:assembleDebug` — BUILD SUCCEEDED - [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED Reviewed By: cortinico Differential Revision: D104228879
…solution (#56733) Summary: - Remove `hermesV1Enabled` / `react.hermesV1Enabled` Gradle property and all branching it controls - Rename `HERMES_V1_VERSION_NAME` to `HERMES_VERSION_NAME` in `version.properties` - Remove `hermesV1Enabled` from `PrivateReactExtension`, `ProjectUtils`, `PropertyUtils`, `ReactPlugin` - Simplify `DependencyUtils.Coordinates` to single Hermes version - Make `-DHERMESVM_HEAP_HV_MODE=HEAP_HV_PREFER32` CMake flag unconditional - Remove `-DHERMES_V1_ENABLED=1` CMake argument from `ReactAndroid` and Fantom builds - Delete `hermesV1Enabled=true` from `gradle.properties` - Update all Gradle plugin tests ## Changelog: [Android][Removed] - Remove hermesV1Enabled and simplify the code ## Test plan - [x] Gradle plugin: `./gradlew -p packages/gradle-plugin build` — BUILD SUCCESSFUL, all tests pass - [x] Android: `./gradlew :packages:rn-tester:android:app:assembleDebug` — BUILD SUCCESSFUL Reviewed By: cortinico Differential Revision: D104244582
Summary: - Remove `RCT_HERMES_V1_ENABLED` environment variable from `react_native_pods.rb` - Simplify `jsengine.rb` to always use `.hermesversion` tag file - Remove conditional `HERMES_V1_ENABLED=1` preprocessor definition from `utils.rb` - Simplify `hermes-engine.podspec`: always read `HERMES_VERSION_NAME`, use V1 source files, remove legacy inspector subspecs - Simplify `hermes-utils.rb`: remove `hermes_v1_enabled()` function, always use `250829098.0.0-stable` branch, always use `.hermesversion` tag file ## Changelog: [iOS][Removed] - Remove the RCT_HERMES_V1_ENABLED from Cocoapods ## Test plan - [x] iOS: `bundle exec pod install` — success - [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED Reviewed By: cortinico Differential Revision: D104247277
meta-codesync
Bot
force-pushed
the
export-D104247277
branch
from
e0db644 to
a7624f0
Compare
cipolleschi
pushed a commit
that referenced
this pull request
May 8, 2026
Summary: Pull Request resolved: #56735 - Remove `RCT_HERMES_V1_ENABLED` environment variable from `react_native_pods.rb` - Simplify `jsengine.rb` to always use `.hermesversion` tag file - Remove conditional `HERMES_V1_ENABLED=1` preprocessor definition from `utils.rb` - Simplify `hermes-engine.podspec`: always read `HERMES_VERSION_NAME`, use V1 source files, remove legacy inspector subspecs - Simplify `hermes-utils.rb`: remove `hermes_v1_enabled()` function, always use `250829098.0.0-stable` branch, always use `.hermesversion` tag file ## Changelog: [iOS][Removed] - Remove the RCT_HERMES_V1_ENABLED from Cocoapods ## Test plan - [x] iOS: `bundle exec pod install` — success - [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED Differential Revision: D104247277 Reviewed By: cortinico
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCT_HERMES_V1_ENABLEDenvironment variable fromreact_native_pods.rbjsengine.rbto always use.hermesversiontag fileHERMES_V1_ENABLED=1preprocessor definition fromutils.rbhermes-engine.podspec: always readHERMES_VERSION_NAME, use V1 source files, remove legacy inspector subspecshermes-utils.rb: removehermes_v1_enabled()function, always use250829098.0.0-stablebranch, always use.hermesversiontag fileChangelog:
[iOS][Removed] - Remove the RCT_HERMES_V1_ENABLED from Cocoapods
Test plan
bundle exec pod install— successxcodebuildrn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDEDReviewed By: cortinico
Differential Revision: D104247277