Remove dual Hermes version outputs from CI workflows (#56739)#56739
Open
cipolleschi wants to merge 5 commits intofacebook:mainfrom
Open
Remove dual Hermes version outputs from CI workflows (#56739)#56739cipolleschi wants to merge 5 commits intofacebook:mainfrom
cipolleschi wants to merge 5 commits intofacebook:mainfrom
Conversation
added 2 commits
May 8, 2026 06:57
…oad the correct commit data. Differential Revision: D104228879
…oad the correct commit data. Differential Revision: D104244582
meta-cla
Bot
added
the
CLA Signed
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104381269. |
…56735) Summary: Pull Request resolved: facebook#56735 - Remove `RCT_HERMES_V1_ENABLED` environment variable from `react_native_pods.rb` - Simplify `jsengine.rb` to always use `.hermesversion` tag file - Remove conditional `HERMES_V1_ENABLED=1` preprocessor definition from `utils.rb` - Simplify `hermes-engine.podspec`: always read `HERMES_VERSION_NAME`, use V1 source files, remove legacy inspector subspecs - Simplify `hermes-utils.rb`: remove `hermes_v1_enabled()` function, always use `250829098.0.0-stable` branch, always use `.hermesversion` tag file ## Changelog: [iOS][Removed] - Remove the RCT_HERMES_V1_ENABLED from Cocoapods ## Test plan - [x] iOS: `bundle exec pod install` — success - [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED Differential Revision: D104247277 Reviewed By: cortinico
…ebook#56737) Summary: Pull Request resolved: facebook#56737 - Remove `sdks/.hermesv1version` from `package.json` files array — only `.hermesversion` remains - Simplify `hermes-utils.js`: remove `readHermesV1Tag()`, `HERMES_V1_TAG_FILE_PATH`; `setHermesTag()` takes single argument - Simplify `scripts/releases/utils/hermes-utils.js`: single version in `getLatestHermesNightlyVersion()` and `updateHermesRuntimeDependenciesVersions()` - Simplify `bump-hermes-version.js`: remove `--v1-tag` and `--hermes-v1-version` CLI options - Simplify `release-hermes-for-branch-cut.js`: remove legacy branch/workflow/PR logic, keep only single Hermes branch ## Changelog: [General][Changed] - Simplified build JS Hermes infrastructure for the Release ## Test plan - [x] JS tests: `yarn jest --no-watchman hermes-utils-test.js` — 5/5 tests pass Differential Revision: D104380961
Summary: Pull Request resolved: facebook#56739 ## Summary - Simplify `publish-release.yml`: remove `HERMES_V1_VERSION` output, read only `HERMES_VERSION_NAME` - Simplify `create-draft-release.yml`: remove `hermesV1Version` input - Simplify `createDraftRelease.js`: remove `hermesV1Version` parameter and "Hermes V1 dSYMS" section from release notes - Simplify `prebuild-ios-core.yml`: read `HERMES_VERSION_NAME` instead of `HERMES_V1_VERSION_NAME` - Delete unused `prepare-hermes-v1-app` action, `hermes-v1.patch`, and `selectLatestHermesV1Version.js` ## Changelog: [Internal] ## Test plan - [x] JS tests: `yarn jest --no-watchman createDraftRelease-test.js` — 9/9 tests pass Differential Revision: D104381269
meta-codesync
Bot
changed the title
cipolleschi
force-pushed
the
export-D104381269
branch
from
a605b2a to
e14a0ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Summary
publish-release.yml: removeHERMES_V1_VERSIONoutput, read onlyHERMES_VERSION_NAMEcreate-draft-release.yml: removehermesV1VersioninputcreateDraftRelease.js: removehermesV1Versionparameter and "Hermes V1 dSYMS" section from release notesprebuild-ios-core.yml: readHERMES_VERSION_NAMEinstead ofHERMES_V1_VERSION_NAMEprepare-hermes-v1-appaction,hermes-v1.patch, andselectLatestHermesV1Version.jsChangelog:
[Internal]
Test plan
yarn jest --no-watchman createDraftRelease-test.js— 9/9 tests passDifferential Revision: D104381269