[compiler]: add useFormContext to react-hook-form known incompatible APIs#36438
Open
tatsuya-asami wants to merge 1 commit intofacebook:mainfrom
Open
[compiler]: add useFormContext to react-hook-form known incompatible APIs#36438tatsuya-asami wants to merge 1 commit intofacebook:mainfrom
useFormContext to react-hook-form known incompatible APIs#36438tatsuya-asami wants to merge 1 commit intofacebook:mainfrom
Conversation
…e APIs facebook#34027 added a check for react-hook-form's `useForm().watch`, but not `useFormContext().watch`. The same `watch` function is exposed via `useFormContext()` and has the same memoization incompatibility, also discussed in the community at https://github.com/orgs/react-hook-form/discussions/12524.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#34027 added a check for react-hook-form's
useForm().watch, but not foruseFormContext().watch.useFormContext()exposes the samewatchfunction: when React Compiler memoizes calls to it, the watched value goes stale and form updates are not reflected in the UI.This PR mirrors the existing
useFormrule ontouseFormContextso the compiler skips memoization in this case as well, also discussed in the community.