Skip to content

refactor(types): migrate from tsd to tstyche#175

Merged
Tony133 merged 5 commits intofastify:mainfrom
Puppo:migrate-to-tstyche
May 7, 2026
Merged

refactor(types): migrate from tsd to tstyche#175
Tony133 merged 5 commits intofastify:mainfrom
Puppo:migrate-to-tstyche

Conversation

@Puppo
Copy link
Copy Markdown
Contributor

@Puppo Puppo commented May 7, 2026 •
edited
Loading

@Puppo
chore: migrate type tests from tsd to tstyche
70f38a3 
Replace tsd dependency with tstyche for TypeScript type testing.
Rename type test file from .test-d.ts to .tst.ts.
Create tsconfig.json with node16 module resolution.
Add @types/node for Buffer type definitions.

Converted assertions:
- expectType<T>(...) -> expect(...).type.toBe<T>()
- expectError(...) -> commented (TypeScript errors naturally with tstyche)
@Puppo Puppo changed the title chore: migrate type tests from tsd to tstyche refactor(types): migrate type tests from tsd to tstyche May 7, 2026
@Fdawgs
Copy link
Copy Markdown
Member

Fdawgs commented May 7, 2026

@Puppo please follow the style @Tony133 has been using of linking to the original PRs so these can all be tracked in one place, rather than this AI-generated one.

@Puppo
Copy link
Copy Markdown
Contributor Author

Puppo commented May 7, 2026

@Puppo please follow the style @Tony133 has been using of linking to the original PRs so these can all be tracked in one place, rather than this AI-generated one.

Yes, it's in draft! I need to review it a moment

@Puppo Puppo force-pushed the migrate-to-tstyche branch from 9b44582 to c77643c Compare May 7, 2026 07:23
@Puppo Puppo changed the title refactor(types): migrate type tests from tsd to tstyche refactor(types): migrate from tsd to tstyche May 7, 2026
@Puppo Puppo marked this pull request as ready for review May 7, 2026 07:27
@Puppo
Copy link
Copy Markdown
Contributor Author

Puppo commented May 7, 2026

@Puppo please follow the style @Tony133 has been using of linking to the original PRs so these can all be tracked in one place, rather than this AI-generated one.

Yes, it's in draft! I need to review it a moment

@Fdawgs done! And ready for review @Tony133

Tony133
Tony133 reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Tony133 Tony133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥 I'm waiting for the final review from @mrazauskas, then we'll proceed with the merge! 🚀

mrazauskas
mrazauskas reviewed May 7, 2026
View reviewed changes
Comment thread types/index.tst.ts
Comment thread tsconfig.json Outdated
@Puppo Puppo requested review from Tony133 and mrazauskas May 7, 2026 11:29
@mrazauskas
Copy link
Copy Markdown

mrazauskas commented May 7, 2026

lgtm

@Tony133 Tony133 merged commit 8e861a0 into fastify:main May 7, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tony133 Tony133 Tony133 approved these changes

@mrazauskas mrazauskas Awaiting requested review from mrazauskas

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Puppo @Fdawgs @mrazauskas @Tony133