chore: update vite-plus and related packages to 0.1.15-alpha.1#5
chore: update vite-plus and related packages to 0.1.15-alpha.1#5fengmk2 wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.gh.lumenfield.work/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new pre-commit hook and updates several dependencies, including vite-plus, vite, and vitest, to an alpha version (0.1.15-alpha.1). The review feedback emphasizes the risks associated with using pre-release versions for core build and testing tools, which could lead to instability across the workspace. Additionally, it is suggested that vite-plus be moved to devDependencies to better reflect its role as a development tool.
| "virtua": "0.48.8", | ||
| "vite-plugin-pwa": "1.2.0", | ||
| "vite-plus": "0.1.12", | ||
| "vite-plus": "0.1.15-alpha.1", |
There was a problem hiding this comment.
Using a pre-release version (0.1.15-alpha.1) for vite-plus can introduce instability. It is recommended to use stable releases. Additionally, since vite-plus appears to be a development tool, it should be moved to devDependencies.
| sharp: 0.34.5 | ||
| vite: npm:@voidzero-dev/vite-plus-core@0.1.12 | ||
| vitest: npm:@voidzero-dev/vite-plus-test@0.1.12 | ||
| vite: npm:@voidzero-dev/vite-plus-core@0.1.15-alpha.1 |
There was a problem hiding this comment.
Overriding vite to an alpha version (0.1.15-alpha.1) workspace-wide is risky. Pre-release versions can be unstable and may break the build process for all packages in the workspace. It is strongly recommended to use a stable version of vite to ensure reliability.
| "typescript": "6.0.2", | ||
| "unplugin-vue-markdown": "30.0.0", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.12", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.15-alpha.1", |
There was a problem hiding this comment.
Using an alpha version (0.1.15-alpha.1) for vitest can introduce instability to the testing workflow. It is advisable to use stable versions to ensure CI/CD and local development are not disrupted by potential bugs in the pre-release.
| vite: npm:@voidzero-dev/vite-plus-core@0.1.12 | ||
| vitest: npm:@voidzero-dev/vite-plus-test@0.1.12 | ||
| vite: npm:@voidzero-dev/vite-plus-core@0.1.15-alpha.1 | ||
| vitest: npm:@voidzero-dev/vite-plus-test@0.1.15-alpha.1 |
There was a problem hiding this comment.
Overriding vitest to an alpha version (0.1.15-alpha.1) across the workspace can lead to an unstable testing environment. To maintain a reliable testing pipeline, it is recommended to use stable releases.
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
autofix.ci
2 participants
🔗 Linked issue
🧭 Context
📚 Description