Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
![gemini-code-assist[bot]](https://avatars.gh.lumenfield.work/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several significant updates, including a new accessible Tab component system, a split sparkline view for trend charts, and an increase in the maximum package selection limit from 4 to 10. It also implements a security headers module with Content-Security-Policy support, refactors git provider API handling, and provides extensive translation updates across multiple locales. Feedback highlights critical issues in the new components, specifically missing imports for lightenOklch and applyEllipsis in SplitSparkline.vue, as well as an undefined datetimeFormatterOptions property in TrendsChart.vue.
| ? (lightenOklch(unit.color, 0.5) ?? seriesColor) | ||
| : (lightenColor(seriesColor, 0.5) ?? seriesColor) // palette uses hex colours |
There was a problem hiding this comment.
The variable lightenOklch is used but not imported in the script setup. This will cause a runtime error.
| /> | ||
| </svg> | ||
| </div> | ||
| {{ applyEllipsis(dataset?.[i]?.name ?? '', 28) }} |
There was a problem hiding this comment.
The function applyEllipsis is used in the template but is not defined or imported in the script setup.
| <ChartSplitSparkline | ||
| :dataset="normalisedDataset" | ||
| :dates="chartData.dates" | ||
| :datetimeFormatterOptions |
There was a problem hiding this comment.
The property datetimeFormatterOptions is used in the template but is not defined in the script setup of this component.
1 participant
Upgrade vite-plus and related packages to 0.1.15-alpha.7