Skip to content

chore: upgrade vite-plus to 0.1.16#8

Draft
fengmk2 wants to merge 3 commits intomainfrom
upgrade-vite-plus-0.1.16
Draft

chore: upgrade vite-plus to 0.1.16#8
fengmk2 wants to merge 3 commits intomainfrom
upgrade-vite-plus-0.1.16

Conversation

@fengmk2
Copy link
Copy Markdown
Owner

@fengmk2 fengmk2 commented Apr 9, 2026

🔗 Linked issue

🧭 Context

Disable vitest/require-mock-type-parameters lint rule introduced in the new version.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates vite-plus and vitest to version 0.1.16, along with updates to oxlint and oxfmt. A new pre-commit hook was added but lacks a shebang for portability. Additionally, a dependency version mismatch exists in the lockfile where esbuild remains at version 0.27.7 despite a new requirement for version 0.28.0.

Comment thread pnpm-lock.yaml
'@vitejs/devtools': ^0.0.0-alpha.31
esbuild: ^0.27.0
'@vitejs/devtools': ^0.1.0
esbuild: ^0.28.0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The peer dependency requirement for esbuild has been updated to ^0.28.0 in @voidzero-dev/vite-plus-core@0.1.16. However, the lockfile indicates that esbuild@0.27.7 is still being resolved and passed to this package (as seen in the resolution strings for vite-plus-core and other packages in the dependency graph). This version mismatch does not satisfy the new requirement and may lead to installation warnings or runtime issues. Please update esbuild in your dependencies to a version that satisfies ^0.28.0.

Comment thread .vite-hooks/pre-commit
@@ -0,0 +1 @@
vp staged
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pre-commit hook script is missing a shebang. Adding #!/bin/sh ensures that the script is executed using the correct shell environment and improves portability across different systems.

#!/bin/sh
vp staged

@fengmk2 fengmk2 force-pushed the upgrade-vite-plus-0.1.16 branch from deffa08 to ec428f4 Compare April 9, 2026 15:41
Disable vitest/require-mock-type-parameters lint rule introduced in the new version.
@fengmk2 fengmk2 force-pushed the upgrade-vite-plus-0.1.16 branch from ec428f4 to b7e7514 Compare April 9, 2026 15:45
@github-actions github-actions Bot added stale and removed stale labels May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants