Conversation
There was a problem hiding this comment.
Code Review
This pull request updates vite-plus and vitest (aliased to @voidzero-dev/vite-plus-test) to version 0.1.17-alpha.4, while also bumping several internal dependencies such as oxfmt and oxlint. Feedback indicates that the upgrade introduces stricter peer dependency requirements for @vitest packages and vite that are not currently met by the project, which may lead to dependency resolution warnings or errors.
| '@vitest/coverage-istanbul': 4.1.4 | ||
| '@vitest/coverage-v8': 4.1.4 | ||
| '@vitest/ui': 4.1.4 | ||
| happy-dom: '*' | ||
| jsdom: '*' | ||
| vite: ^6.0.0 || ^7.0.0 || ^8.0.0-0 | ||
| vite: ^6.0.0 || ^7.0.0 || ^8.0.0 |
There was a problem hiding this comment.
The upgrade to @voidzero-dev/vite-plus-test@0.1.17-alpha.4 introduces stricter peer dependency requirements that are not fully met by the current project configuration:
- Vitest related packages: It now requires version
4.1.4for@vitest/coverage-v8,@vitest/coverage-istanbul, and@vitest/ui. The project is currently using version4.1.2(e.g., for@vitest/coverage-v8as seen in line 277). - Vite: The peer dependency range for
vitechanged from^6.0.0 || ^7.0.0 || ^8.0.0-0to^6.0.0 || ^7.0.0 || ^8.0.0. Since the project usesvite@8.0.0-beta.18, this new range will no longer match, potentially causing pnpm warnings or resolution issues.
Consider updating the @vitest/* packages to 4.1.4 in package.json and verifying if the vite peer dependency range change was intentional in the upstream package.
79fe3c1 to
7e607a1
Compare
|
| 📦 Package | 📋 Versions |
|---|---|
| h3 | 5 versions
h3@2.0.1-rc.11 h3@2.0.1-rc.16 h3@2.0.1-rc.20 |
| glob | 5 versions
|
| @rolldown/pluginutils | 5 versions
@rolldown/pluginutils@1.0.0-rc.9 |
| @oxc-project/types | 6 versions
|
💡 To find out what depends on a specific package, run: pnpm -r why example-package
📊 Dependency Size Changes
Warning
This PR adds 410.1 kB of new dependencies, which exceeds the threshold of 200 kB.
| 📦 Package | 📏 Size |
|---|---|
| @oxlint/binding-linux-x64-gnu@1.58.0 → @oxlint/binding-linux-x64-gnu@1.60.0 | 282.7 kB |
| @voidzero-dev/vite-plus-test@0.1.16 → @voidzero-dev/vite-plus-test@0.1.17-alpha.5 | 70.3 kB |
| oxlint@1.58.0 → oxlint@1.60.0 | 25.2 kB |
| @voidzero-dev/vite-plus-linux-x64-gnu@0.1.16 → @voidzero-dev/vite-plus-linux-x64-gnu@0.1.17-alpha.5 | 12.3 kB |
| @oxfmt/binding-linux-x64-gnu@0.43.0 → @oxfmt/binding-linux-x64-gnu@0.45.0 | 8.2 kB |
| oxfmt@0.43.0 → oxfmt@0.45.0 | 7.4 kB |
| vite-plus@0.1.16 → vite-plus@0.1.17-alpha.5 | 3.3 kB |
| @voidzero-dev/vite-plus-core@0.1.16 → @voidzero-dev/vite-plus-core@0.1.17-alpha.5 | 711 B |
| vitest@@voidzero-dev/vite-plus-test@0.1.17-alpha.5 | Unknown |
| vitest@@voidzero-dev/vite-plus-test@0.1.16 | Unknown |
| vite@@voidzero-dev/vite-plus-core@0.1.17-alpha.5 | Unknown |
| vite@@voidzero-dev/vite-plus-core@0.1.16 | Unknown |
| @oxc-project/runtime@0.123.0 → @oxc-project/runtime@0.124.0 | 0 B |
| @oxc-project/types@0.123.0 → @oxc-project/types@0.124.0 | 0 B |
Total size change: 410.1 kB
Upgrade vite-plus and related packages to 0.1.17-alpha.4