refactor: follow up PR with updates based on feedback#1244
Merged
russellwheatley merged 9 commits intomainfrom May 8, 2025
Merged
refactor: follow up PR with updates based on feedback#1244russellwheatley merged 9 commits intomainfrom
russellwheatley merged 9 commits intomainfrom
Conversation
peterfriese
requested changes
Apr 30, 2025
Contributor
peterfriese
left a comment
There was a problem hiding this comment.
Left a few more comments
peterfriese
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains the following:
AuthUI. Example -FacebookProviderSwifthas changed toFacebookProviderAuthUI.labelargument rather than using anonymous closure.ContentViewfor SwiftUI example app.Let me know what you think, @peterfriese. Just as an aside, the UI Views don't look great at the moment as we're awaiting UI design.