Skip to content

refactor: remove authViewRoutes and remove error API from AuthService and moved to View layer.#1297

Merged
russellwheatley merged 8 commits intodevelopmentfrom
api-refactor
Nov 6, 2025
Merged

refactor: remove authViewRoutes and remove error API from AuthService and moved to View layer.#1297
russellwheatley merged 8 commits intodevelopmentfrom
api-refactor

Conversation

@russellwheatley
Copy link
Copy Markdown
Member

@russellwheatley russellwheatley commented Nov 6, 2025 •
edited
Loading

Changes

  • Removed unused authViewRoutes from AuthService.
  • Refactored error modal from AuthService by moving it to the View layer. The AuthService shouldn't be handling this and it isn't part of the API design.
  • made reportError() optional so user can still use buttons without needing to pass into environment.

demolaf
demolaf reviewed Nov 6, 2025
View reviewed changes
Comment thread FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/AuthPickerView.swift Outdated
demolaf
demolaf reviewed Nov 6, 2025
View reviewed changes
Comment thread FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/AuthPickerView.swift
}

/// Closure for reporting errors from child views
private func reportError(_ error: Error) {
Copy link
Copy Markdown
Member

@demolaf demolaf Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@russellwheatley russellwheatley merged commit 7e1dcee into development Nov 6, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@demolaf demolaf demolaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@russellwheatley @demolaf