Skip to content

fix: FieldMask not exported from firestore#265

Open
OutdatedGuy wants to merge 2 commits intofirebase:mainfrom
OutdatedGuy:fix/field-mask
Open

fix: FieldMask not exported from firestore#265
OutdatedGuy wants to merge 2 commits intofirebase:mainfrom
OutdatedGuy:fix/field-mask

Conversation

@OutdatedGuy
Copy link
Copy Markdown

Related Issues

fixes #264

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).

  • I have updated the CHANGELOG.md of the relevant packages.
    Changelog files must be edited under the form:

    ## Unreleased fix/major/minor
    
    - Description of your change. (thanks to @yourGithubId)
  • If this contains new features or behavior changes,
    I have updated the documentation to match those changes.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request exports the FieldMask class from the google_cloud_firestore package and updates the CHANGELOG.md to document this fix. I have no feedback to provide.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@24ddbf0). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage        ?   74.83%           
=======================================
  Files           ?      105           
  Lines           ?     6863           
  Branches        ?        0           
=======================================
  Hits            ?     5136           
  Misses          ?     1727           
  Partials        ?        0           
Flag Coverage Δ
unittests 74.83% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FieldMask is not available

2 participants