Skip to content

Added type information to error matching #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xperiandri merged 3 commits into from
Oct 30, 2025
Merged

Added type information to error matching #543

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0eb74ac
Added type information to error matching
Thorium Oct 29, 2025
bd22c1f
Update src/FSharp.Data.GraphQL.Server/Values.fs
Thorium Oct 30, 2025
566a9e3
Update src/FSharp.Data.GraphQL.Server/Values.fs
Thorium Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/FSharp.Data.GraphQL.Server/Values.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,10 @@ let rec internal compileByType
if ReflectionHelper.isAssignableWithUnwrap inputType paramType then
allParameters.Add (struct (ValueSome field, param))
else
// TODO: Consider improving by specifying type mismatches
typeMismatchParameters.Add param.Name |> ignore
let expectedType = inputDef.Type.ToString ()
let actualType = paramType.ToString ()
typeMismatchParameters.Add (param.Name, expectedType, actualType)
Comment thread
Thorium marked this conversation as resolved.
Outdated
|> ignore
| None ->
if
ReflectionHelper.isParameterSkippable param
Expand Down Expand Up @@ -172,10 +174,20 @@ let rec internal compileByType
$"Input object %s{objDef.Name} refers to type '%O{objType}', but skippable '%s{``params``}' GraphQL fields and constructor parameters do not match"
InvalidInputTypeException (message, skippableMismatchParameters.ToImmutableHashSet ())
if typeMismatchParameters.Any () then

let typeMismatchParameterNames = HashSet ()

let details =
typeMismatchParameters
|> Seq.map (fun (name, expected, actual) ->
typeMismatchParameterNames.Add name |> ignore
sprintf "Parameter '%s': expected %s, got %s" name expected actual)
Comment thread
Thorium marked this conversation as resolved.
Outdated
|> String.concat "; "

let message =
let ``params`` = String.Join ("', '", typeMismatchParameters)
$"Input object %s{objDef.Name} refers to type '%O{objType}', but GraphQL fields '%s{``params``}' have different types than constructor parameters"
InvalidInputTypeException (message, typeMismatchParameters.ToImmutableHashSet ())
$"Input object %s{objDef.Name} refers to type '%O{objType}', but GraphQL fields '%s{``params``}' have different types than constructor parameters: {details}"
InvalidInputTypeException (message, typeMismatchParameterNames.ToImmutableHashSet ())
]
match exceptions with
| [] -> ()
Expand Down