Skip to content

fix: stop leaking prePromptMessageCount to daemon in afterTurn #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xDarkicex wants to merge 1 commit into from
Closed

fix: stop leaking prePromptMessageCount to daemon in afterTurn #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/context-engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,6 @@ export function buildContextEngineFactory(
sessionKey: args.sessionKey,
userId: args.userId,
messages,
prePromptMessageCount: args.prePromptMessageCount,
isHeartbeat: args.isHeartbeat,
});
await performAfterTurnPredictiveCompaction({
Expand All @@ -723,8 +722,11 @@ export function buildContextEngineFactory(
}
const rpc = await runtime.getRpc();
const result = await rpc.call("after_turn_kernel", {
...args,
sessionId: args.sessionId,
sessionKey: args.sessionKey,
userId: args.userId,
messages,
isHeartbeat: args.isHeartbeat,
});
await performAfterTurnPredictiveCompaction({
sessionId: args.sessionId,
Expand Down
4 changes: 2 additions & 2 deletions test/integration/host-flow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ test("compact omits invalid currentTokenCount values from the wire request", asy
assert.equal("currentTokenCount" in params, false);
});

test("afterTurn forwards message arrays and pre-prompt counts correctly", async () => {
test("afterTurn forwards only daemon-relevant fields, strips prePromptMessageCount", async () => {
const rpc = new StaticContractRpc();
const recallCache = createRecallCache<SearchResult>();
const cfg: PluginConfig = { rpcTimeoutMs: 1000 };
Expand All @@ -469,7 +469,7 @@ test("afterTurn forwards message arrays and pre-prompt counts correctly", async
assert.ok(params, "Expected after_turn_kernel to be called");
assert.equal(params.sessionId, "test-session");
assert.equal(params.userId, "test-user");
assert.equal(params.prePromptMessageCount, 2);
assert.equal("prePromptMessageCount" in params, false, "prePromptMessageCount must not leak to daemon — daemon defaults to 0 and uses content-hash dedup");
assert.equal(params.isHeartbeat, false);
assert.deepEqual(params.messages, mockMessages);
});
Expand Down