Skip to content

WinUI plugin enhancements and add MVVM Toolkit skill#1643

Open
alvinashcraft wants to merge 2 commits intogithub:stagedfrom
alvinashcraft:alvinashcraft/staged-mvvm-toolkit-plugin
Open

WinUI plugin enhancements and add MVVM Toolkit skill#1643
alvinashcraft wants to merge 2 commits intogithub:stagedfrom
alvinashcraft:alvinashcraft/staged-mvvm-toolkit-plugin

Conversation

@alvinashcraft
Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, or workflow file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, or workflow with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the staged branch for this pull request.

Description

Adding a new MVVM Toolkit skill with some additional reference files to add details to different aspects of its usage. I also updated the WinUI 3 plugin to include the new skill plus the existing MS Store CLI and winapp CLI skills.


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • Update to existing instruction, prompt, agent, plugin, skill, or workflow.
  • Other (please specify):

Additional Notes

I would like a review from @niels9001 since he's the original author of the WinUI plugin. I don't want to create too much bloat in that plugin and have it not function as originally intended for UWP migrations.


By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

Copilot AI review requested due to automatic review settings May 7, 2026 12:27
@alvinashcraft alvinashcraft requested a review from aaronpowell as a code owner May 7, 2026 12:27
@github-actions github-actions Bot added instructions PR touches instructions new-submission PR adds at least one new contribution plugin PR touches plugins skills PR touches skills skill-check-warning Skill validator reported warnings labels May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

🔍 Skill Validator Results

⚠️ Warnings or advisories found

Scope Checked
Skills 3
Agents 1
Total 4
Severity Count
--- ---:
❌ Errors 0
⚠️ Warnings 1
ℹ️ Advisories 0

Summary

Level Finding
ℹ️ Found 3 skill(s)
ℹ️ [mvvm-toolkit] 📊 mvvm-toolkit: 2,553 BPE tokens [chars/4: 2,696] (standard ~), 14 sections, 9 code blocks
ℹ️ [mvvm-toolkit] ⚠ Skill is 2,553 BPE tokens (chars/4 estimate: 2,696) — approaching "comprehensive" range where gains diminish.
ℹ️ [mvvm-toolkit-di] 📊 mvvm-toolkit-di: 1,998 BPE tokens [chars/4: 2,339] (detailed ✓), 13 sections, 10 code blocks
ℹ️ [mvvm-toolkit-messenger] 📊 mvvm-toolkit-messenger: 1,946 BPE tokens [chars/4: 2,214] (detailed ✓), 17 sections, 14 code blocks
ℹ️ ✅ All checks passed (3 skill(s))
Full validator output ```text Found 3 skill(s) [mvvm-toolkit] 📊 mvvm-toolkit: 2,553 BPE tokens [chars/4: 2,696] (standard ~), 14 sections, 9 code blocks [mvvm-toolkit] ⚠ Skill is 2,553 BPE tokens (chars/4 estimate: 2,696) — approaching "comprehensive" range where gains diminish. [mvvm-toolkit-di] 📊 mvvm-toolkit-di: 1,998 BPE tokens [chars/4: 2,339] (detailed ✓), 13 sections, 10 code blocks [mvvm-toolkit-messenger] 📊 mvvm-toolkit-messenger: 1,946 BPE tokens [chars/4: 2,214] (detailed ✓), 17 sections, 14 code blocks ✅ All checks passed (3 skill(s)) ```

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an MVVM Toolkit skill and integrates it into the existing winui3-development plugin so WinUI 3 developers can reference MVVM patterns alongside packaging and Store publishing workflows.

Changes:

  • Added new mvvm-toolkit skill with focused reference pages (generators, commands, messenger, DI, validation, troubleshooting, walkthrough).
  • Added a new mvvm-toolkit instruction file for C#/XAML/.csproj guidance when using CommunityToolkit.Mvvm.
  • Expanded the winui3-development plugin metadata/docs to include mvvm-toolkit, winapp-cli, and msstore-cli, and updated marketplace/docs indices accordingly.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
skills/mvvm-toolkit/SKILL.md New MVVM Toolkit skill entrypoint and high-level guidance with links to bundled references.
skills/mvvm-toolkit/references/source-generators.md Reference for MVVM Toolkit source generator attributes and generated code behavior.
skills/mvvm-toolkit/references/relaycommand-cookbook.md Recipes for [RelayCommand], RelayCommand, and AsyncRelayCommand usage.
skills/mvvm-toolkit/references/messenger-patterns.md Messenger usage patterns (implementations, channels, request/reply, lifetimes).
skills/mvvm-toolkit/references/dependency-injection.md Guidance for using Microsoft.Extensions.DependencyInjection with MVVM Toolkit.
skills/mvvm-toolkit/references/validation.md Validation guidance for ObservableValidator and DataAnnotations.
skills/mvvm-toolkit/references/troubleshooting.md Common generator diagnostics and common MVVM Toolkit troubleshooting items.
skills/mvvm-toolkit/references/end-to-end-walkthrough.md End-to-end WinUI 3 walkthrough tying together MVVM Toolkit + DI + messaging.
instructions/mvvm-toolkit.instructions.md New instructions file defining MVVM Toolkit conventions across C#/XAML projects.
plugins/winui3-development/README.md Updated plugin README to document the expanded scope and new slash commands.
plugins/winui3-development/.github/plugin/plugin.json Updated plugin metadata, tags, version, and included skills list.
docs/README.skills.md Added mvvm-toolkit to the skills index.
docs/README.instructions.md Added mvvm-toolkit instructions to the instructions index.
docs/README.plugins.md Updated winui3-development plugin listing (description, item count, tags).
.github/plugin/marketplace.json Updated marketplace entry for winui3-development description/version.

Comment thread skills/mvvm-toolkit/references/messenger-patterns.md Outdated
Copy link
Copy Markdown
Contributor

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the validator notes, there is a risk on the mvvm-toolkit still being large, but I see that you've already done an additional pass on it to condense it down and I don't think without splitting it (which is arguably detrimental) you can achieve much improvement on what's there.

I'll give it a few days to see if the original plugin author replies, but generally speaking it is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instructions PR touches instructions new-submission PR adds at least one new contribution plugin PR touches plugins skill-check-warning Skill validator reported warnings skills PR touches skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants