Skip to content

CFG: Consider logical not a post order operation. #21811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
michaelnebel wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Draft

CFG: Consider logical not a post order operation. #21811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions shared/controlflow/codeql/controlflow/ControlFlowGraph.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,13 +519,14 @@ module Make0<LocationSig Location, AstSig<Location> Ast> {
or
n instanceof GotoStmt
or
n instanceof LogicalNotExpr
or
n instanceof Expr and
exists(getChild(n, _)) and
not Input1::preOrderExpr(n) and
not n instanceof LogicalAndExpr and
not n instanceof LogicalOrExpr and
not n instanceof NullCoalescingExpr and
not n instanceof LogicalNotExpr and
not n instanceof ConditionalExpr and
not n instanceof Switch and
not n instanceof Case
Expand Down Expand Up @@ -1454,8 +1455,13 @@ module Make0<LocationSig Location, AstSig<Location> Ast> {
n1.isBefore(notexpr) and
n2.isBefore(notexpr.getOperand())
or
exists(BooleanSuccessor t |
n1.isAfterValue(notexpr.getOperand(), t) and
exists(BooleanSuccessor t, PreControlFlowNode operand |
operand.isAfterValue(notexpr.getOperand(), t)
|
n1 = operand and
n2.isIn(notexpr)
or
n1.isIn(notexpr) and
n2.isAfterValue(notexpr, t.getDual())
)
)
Expand Down
Loading