Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/webgpu/api/operation/render_pass/resolve.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Test basic render pass resolve behavior for combinations of:
const { colorFormat } = t.params;
t.skipIfTextureFormatNotSupported(colorFormat);
t.skipIfTextureFormatNotResolvable(colorFormat);
// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
if (t.params.transientColorAttachment || t.params.transientDepthStencilAttachment) {
t.skipIfTransientAttachmentNotSupported();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ g.test('increasing_attachments_count')
`
)
.fn(t => {
// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
t.skipIfTransientAttachmentNotSupported();

const maxAttachments = t.device.limits.maxColorAttachments;
Expand Down Expand Up @@ -58,7 +58,7 @@ g.test('overlapping_transient_attachments')
`
)
.fn(t => {
// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
t.skipIfTransientAttachmentNotSupported();

const encoder = t.device.createCommandEncoder();
Expand Down
6 changes: 3 additions & 3 deletions src/webgpu/api/validation/createBindGroup.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ g.test('texture_binding_must_have_correct_usage')
"The test requires 'r32float' multisampled support which compat mode doesn't guarantee."
);

// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
t.skipIfTransientAttachmentNotSupported();
}
Expand Down Expand Up @@ -803,7 +803,7 @@ g.test('storage_texture,usage')

const usage = usage0 | usage1;

// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
t.skipIfTransientAttachmentNotSupported();
}
Expand Down Expand Up @@ -1242,7 +1242,7 @@ g.test('external_texture,texture_view,usage')

const usage = usage0 | usage1;

// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
t.skipIfTransientAttachmentNotSupported();
}
Expand Down
6 changes: 3 additions & 3 deletions src/webgpu/api/validation/createTexture.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ g.test('sampleCount,valid_sampleCount_with_other_parameter_varies')
if ((usage & GPUConst.TextureUsage.RENDER_ATTACHMENT) !== 0) {
t.skipIfTextureFormatNotUsableAsRenderAttachment(format);
}
// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
t.skipIfTransientAttachmentNotSupported();
}
Expand Down Expand Up @@ -1035,7 +1035,7 @@ g.test('texture_usage')
usage,
};

// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
t.skipIfTransientAttachmentNotSupported();
}
Expand Down Expand Up @@ -1075,7 +1075,7 @@ g.test('depthOrArrayLayers_and_mipLevelCount_for_transient_attachments')
.combine('mipLevelCount', [1, 2])
)
.fn(t => {
// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
t.skipIfTransientAttachmentNotSupported();

const { format, depthOrArrayLayers, mipLevelCount } = t.params;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@ g.test('color_attachments,loadOp_storeOp')
t.skipIfTextureFormatNotSupported(format);
t.skipIfTextureFormatNotUsableAsRenderAttachment(format);

// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
if (transientTexture) {
t.skipIfTransientAttachmentNotSupported();
}
Expand Down Expand Up @@ -1129,7 +1129,7 @@ g.test('depth_stencil_attachment,loadOp_storeOp_match_depthReadOnly_stencilReadO

t.skipIfTextureFormatNotSupported(format);

// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
if (transientTexture) {
t.skipIfTransientAttachmentNotSupported();
}
Expand Down
4 changes: 2 additions & 2 deletions src/webgpu/api/validation/texture/bgra8unorm_storage.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ Test that it is invalid to configure a GPUCanvasContext to 'GPUStorageBinding' u
.fn(t => {
const { canvasType, usage } = t.params;

// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
t.skipIfTransientAttachmentNotSupported();
}
Expand Down Expand Up @@ -155,7 +155,7 @@ with 'bgra8unorm-storage' enabled.
.fn(t => {
const { canvasType, usage } = t.params;

// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
t.skipIfTransientAttachmentNotSupported();
}
Expand Down
2 changes: 1 addition & 1 deletion src/webgpu/gpu_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ export class GPUTestBase extends Fixture<GPUTestSubcaseBatchState> {
}

/** Skips this test case if the GPUTextureUsage `TRANSIENT_ATTACHMENT` is *not* supported. */
// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
skipIfTransientAttachmentNotSupported() {
const isTransientAttachmentSupported = 'TRANSIENT_ATTACHMENT' in GPUTextureUsage;
this.skipIf(
Expand Down
4 changes: 2 additions & 2 deletions src/webgpu/idl/constants/flags.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const kTextureUsageExp: {
TRANSIENT_ATTACHMENT: 0x20,
};
g.test('TextureUsage,count').fn(t => {
// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
if (!('TRANSIENT_ATTACHMENT' in GPUTextureUsage)) {
delete kTextureUsageExp.TRANSIENT_ATTACHMENT;
}
Expand All @@ -57,7 +57,7 @@ g.test('TextureUsage,values')
.fn(t => {
const { key } = t.params;

// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
t.skipIf(key === 'TRANSIENT_ATTACHMENT' && !('TRANSIENT_ATTACHMENT' in GPUTextureUsage));

t.assertMember(GPUTextureUsage, kTextureUsageExp, key);
Expand Down
4 changes: 2 additions & 2 deletions src/webgpu/web_platform/canvas/configure.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ g.test('usage')
.fn(t => {
const { canvasType, usage } = t.params;

// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
t.skipIfTransientAttachmentNotSupported();
}
Expand Down Expand Up @@ -355,7 +355,7 @@ g.test('invalid_usage')
.fn(t => {
const { canvasType, format, usage } = t.params;

// MAINTENANCE_TODO(#4509): Remove this when TRANSIENT_ATTACHMENT is added to the WebGPU spec.
// MAINTENANCE_TODO(#4509): Remove this after all implementations have TRANSIENT_ATTACHMENT.
if ((usage & GPUConst.TextureUsage.TRANSIENT_ATTACHMENT) !== 0) {
t.skipIfTransientAttachmentNotSupported();
}
Expand Down
Loading