Conversation
Deploying hydroflow with
|
| Latest commit: |
febe5e6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://115bc30c.hydroflow.pages.dev |
| Branch Preview URL: | https://pr1804.hydroflow.pages.dev |
shadaj
force-pushed
the
pr1804
branch
6 times, most recently
from
2719a19 to
37d7ea1
Compare
MingweiSamuel
approved these changes
Mar 22, 2025
Comment on lines
+945
to
+947
| { | ||
| ret = ret.features(vec!["hydro___feature_runtime_io-uring"]); | ||
| } |
Member
There was a problem hiding this comment.
Does this magic string do anything?
| use super::trybuild_rewriters::ReplaceCrateNameWithStaged; | ||
|
|
||
| pub const HYDRO_RUNTIME_FEATURES: [&str; 1] = ["runtime_measure"]; | ||
| pub const HYDRO_RUNTIME_FEATURES: [&str; 2] = ["runtime_measure", "runtime_io-uring"]; |
Member
There was a problem hiding this comment.
(can also make this &[&str] = &[...] to avoid updating the length)
Member
There was a problem hiding this comment.
(if you're using evenBetterToml can set these in repo .vscode/settings.json to keep more of the old format)
"evenBetterToml.formatter.compactArrays": false,
"evenBetterToml.formatter.columnWidth": 120,
Comment on lines
+13
to
+18
| { | ||
| tokio_uring::builder().entries(4096).start(async move { | ||
| println!("ack start"); | ||
| super::resource_measurement::run(flow).await; | ||
| }) | ||
| } |
Member
There was a problem hiding this comment.
tokio_rt unused here? Can de-duplicate the two async { .. } bodies (also why is one move and one not)
Member
Author
|
Blocked on #1807 |
This was referenced Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.