Skip to content

feat(hydro_lang): add API for safely broadcasting a stream across several keys#2129

Merged
shadaj merged 1 commit intomainfrom
pr2129
Sep 22, 2025
Merged

feat(hydro_lang): add API for safely broadcasting a stream across several keys#2129
shadaj merged 1 commit intomainfrom
pr2129

Conversation

@shadaj
Copy link
Copy Markdown
Member

@shadaj shadaj commented Sep 18, 2025

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Sep 18, 2025

Deploying hydro with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1ed045f
Status: ✅  Deploy successful!
Preview URL: https://d0ef91cb.hydroflow.pages.dev
Branch Preview URL: https://pr2129.hydroflow.pages.dev

View logs

Copy link
Copy Markdown
Member

@MingweiSamuel MingweiSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name is confusing, and also this just discards all the values in the keyed singleton?

@MingweiSamuel
Copy link
Copy Markdown
Member

Not really flat_map nor identical of anything, more like tee to all keys or something

@shadaj
Copy link
Copy Markdown
Member Author

shadaj commented Sep 22, 2025

Name is confusing, and also this just discards all the values in the keyed singleton?

Yeah... I was also unhappy with the name. How about .with_values? In GPU speak this is a "broadcast" but I want to avoid confusion with networking. Open to suggestions.

@shadaj
Copy link
Copy Markdown
Member Author

shadaj commented Sep 22, 2025

Hmm, how about a Stream::clone_with_keys? So inverting who we call the API on...

Copy link
Copy Markdown
Member

@MingweiSamuel MingweiSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repeat_with_keys 🥳

@shadaj shadaj enabled auto-merge (squash) September 22, 2025 19:42
@shadaj shadaj merged commit fc67ee7 into main Sep 22, 2025
19 of 35 checks passed
@shadaj shadaj deleted the pr2129 branch September 22, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants