fix(hydro_lang): add forwardref cycle detection, fix #2080#2399
Open
Shasha-17 wants to merge 4 commits intohydro-project:mainfrom
Open
fix(hydro_lang): add forwardref cycle detection, fix #2080#2399Shasha-17 wants to merge 4 commits intohydro-project:mainfrom
Shasha-17 wants to merge 4 commits intohydro-project:mainfrom
Conversation
MingweiSamuel
changed the title
Member
|
Prev #2159 |
akainth015
reviewed
May 1, 2026
|
|
||
| while let Some(ptr) = stack.pop() { | ||
| if !seen.insert(ptr as usize) { continue; } | ||
| let node: &HydroNode = unsafe { &*ptr }; |
akainth015
reviewed
May 1, 2026
| if !seen.insert(ptr as usize) { continue; } | ||
| let node: &HydroNode = unsafe { &*ptr }; | ||
|
|
||
| if matches!(node, HydroNode::DeferTick { .. }) { return; } |
There was a problem hiding this comment.
Is DeferTick the only operation that can interrupt the cycle?
| stack.push(&**inner as *const _); | ||
| } | ||
|
|
||
| _ => {} |
There was a problem hiding this comment.
Are there any missing arms? New variants would not have their inner dataflow graphs analyzed right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.