refactor(dfir_rs): remove SubgraphId, SubgraphTag, LoopId, LoopTag, simplify StateLifespan#2812
Draft
MingweiSamuel wants to merge 6 commits intomainfrom
Draft
refactor(dfir_rs): remove SubgraphId, SubgraphTag, LoopId, LoopTag, simplify StateLifespan#2812MingweiSamuel wants to merge 6 commits intomainfrom
MingweiSamuel wants to merge 6 commits intomainfrom
Conversation
MingweiSamuel
force-pushed
the
mingwei/delete-subgraph-id
branch
from
acdbd18 to
96a30ad
Compare
Deploying hydro with
|
| Latest commit: |
7374f32
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aa0008dd.hydroflow.pages.dev |
| Branch Preview URL: | https://mingwei-delete-subgraph-id.hydroflow.pages.dev |
MingweiSamuel
force-pushed
the
mingwei/delete-subgraph-id
branch
from
96a30ad to
0551cd2
Compare
MingweiSamuel
added a commit
that referenced
this pull request
Apr 28, 2026
…ateLifespan Remove `SubgraphTag`, `SubgraphId`, `LoopTag`, `LoopId` from `scheduled/mod.rs` — no longer used after removing the `sg_id` parameter from `schedule_subgraph`. Simplify `StateLifespan` to only have `Tick` variant — `Subgraph`, `Loop`, and `Static` variants were unused. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2812
MingweiSamuel
added a commit
that referenced
this pull request
Apr 30, 2026
…ateLifespan Remove `SubgraphTag`, `SubgraphId`, `LoopTag`, `LoopId` from `scheduled/mod.rs` — no longer used after removing the `sg_id` parameter from `schedule_subgraph`. Simplify `StateLifespan` to only have `Tick` variant — `Subgraph`, `Loop`, and `Static` variants were unused. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2812
MingweiSamuel
force-pushed
the
mingwei/delete-subgraph-id
branch
2 times, most recently
from
0a18d5e to
60f7ac8
Compare
MingweiSamuel
added a commit
that referenced
this pull request
Apr 30, 2026
…ateLifespan Remove `SubgraphTag`, `SubgraphId`, `LoopTag`, `LoopId` from `scheduled/mod.rs` — no longer used after removing the `sg_id` parameter from `schedule_subgraph`. Simplify `StateLifespan` to only have `Tick` variant — `Subgraph`, `Loop`, and `Static` variants were unused. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2812
MingweiSamuel
added a commit
that referenced
this pull request
May 1, 2026
…ateLifespan Remove `SubgraphTag`, `SubgraphId`, `LoopTag`, `LoopId` from `scheduled/mod.rs` — no longer used after removing the `sg_id` parameter from `schedule_subgraph`. Simplify `StateLifespan` to only have `Tick` variant — `Subgraph`, `Loop`, and `Static` variants were unused. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2812
MingweiSamuel
force-pushed
the
mingwei/delete-subgraph-id
branch
from
60f7ac8 to
d39854f
Compare
MingweiSamuel
added a commit
that referenced
this pull request
May 1, 2026
…ateLifespan Remove `SubgraphTag`, `SubgraphId`, `LoopTag`, `LoopId` from `scheduled/mod.rs` — no longer used after removing the `sg_id` parameter from `schedule_subgraph`. Simplify `StateLifespan` to only have `Tick` variant — `Subgraph`, `Loop`, and `Static` variants were unused. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2812
MingweiSamuel
force-pushed
the
mingwei/delete-subgraph-id
branch
from
d39854f to
fb0c2a7
Compare
MingweiSamuel
added a commit
that referenced
this pull request
May 1, 2026
…ateLifespan Remove `SubgraphTag`, `SubgraphId`, `LoopTag`, `LoopId` from `scheduled/mod.rs` — no longer used after removing the `sg_id` parameter from `schedule_subgraph`. Simplify `StateLifespan` to only have `Tick` variant — `Subgraph`, `Loop`, and `Static` variants were unused. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2812
MingweiSamuel
force-pushed
the
mingwei/delete-subgraph-id
branch
from
fb0c2a7 to
e7d9a3b
Compare
…urrent_subgraph Remove the unused `sg_id: SubgraphId` parameter from `Context::schedule_subgraph` — inline mode ignores it. Remove `Context::current_subgraph` which always returned a dummy value. Update all operator codegen call sites to drop the `#context.current_subgraph()` argument. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2811
Remove all `schedule_subgraph(false)` calls from operator codegen — these were no-ops since `schedule_subgraph` only acts when `is_external` is `true`. Clean up the `schedule_subgraph(true)` call in meta_graph.rs formatting. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2811
…m slot_vec tags Replace custom `SecondarySlotVec<SubgraphTag, _>` and `SecondarySlotVec<HandoffTag, _>` in DfirMetrics with `slotmap::SecondaryMap<GraphSubgraphId, _>` and `SecondaryMap<GraphNodeId, _>` from dfir_lang. This eliminates the `slotmap_raw_idx` conversion hack in codegen — keys are now reconstructed via `slotmap::KeyData::from_ffi()` which preserves the full key (including version), not just the raw index. Make `dfir_lang` a non-optional dependency of `dfir_rs` (it was already always compiled via `dfir_macro`). Re-export `dfir_lang` and `slotmap` from `dfir_rs` for use in generated code. Remove `HandoffTag` and `HandoffId` from `scheduled/mod.rs` (no longer needed). Update `hydro_lang/src/telemetry/emf.rs` to use `Debug` formatting for slotmap keys instead of `Display`. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2810
Remove the `slotmap_key_ffi` helper and inline `key.data().as_ffi()` at each call site. This makes the symmetry with the generated `KeyData::from_ffi(ffi).into()` more visible. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2810
…ateLifespan Remove `SubgraphTag`, `SubgraphId`, `LoopTag`, `LoopId` from `scheduled/mod.rs` — no longer used after removing the `sg_id` parameter from `schedule_subgraph`. Simplify `StateLifespan` to only have `Tick` variant — `Subgraph`, `Loop`, and `Static` variants were unused. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2812
MingweiSamuel
force-pushed
the
mingwei/delete-subgraph-id
branch
from
e7d9a3b to
7374f32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STACK: #2811 #2810
Remove
SubgraphTag,SubgraphId,LoopTag,LoopIdfromscheduled/mod.rs— no longer used after removing thesg_idparameterfrom
schedule_subgraph.Simplify
StateLifespanto only haveTickvariant —Subgraph,Loop, andStaticvariants were unused.