refactor(dfir_lang): DFIR singleton references, convert singleton state to plain local variables#2829
Draft
MingweiSamuel wants to merge 1 commit intomainfrom
Draft
refactor(dfir_lang): DFIR singleton references, convert singleton state to plain local variables#2829MingweiSamuel wants to merge 1 commit intomainfrom
MingweiSamuel wants to merge 1 commit intomainfrom
Conversation
Deploying hydro with
|
| Latest commit: |
f959a3b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://303fe27f.hydroflow.pages.dev |
| Branch Preview URL: | https://mingwei-singleton-refs-dfir.hydroflow.pages.dev |
MingweiSamuel
changed the title
MingweiSamuel
added a commit
that referenced
this pull request
Apr 30, 2026
Replace `RefCell<T>` with plain `let mut` local variables for singleton state in DFIR operator codegen. Since subgraphs run sequentially in topological order and singleton references create ordering edges, there is never concurrent access — the RefCell runtime borrow checking was unnecessary overhead. Updated 16 files: process_singletons.rs, meta_graph.rs, 13 operator codegen files (fold, fold_keyed, fold_no_replay, reduce, reduce_keyed, reduce_no_replay, scan, scan_async_blocking, state_by, persist, prefix, repeat_n), lattice_bimorphism operator, and LatticeBimorphismPull runtime. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2829
MingweiSamuel
force-pushed
the
mingwei/singleton-refs-dfir
branch
from
21aa0d4 to
87a6b4f
Compare
MingweiSamuel
force-pushed
the
mingwei/delete-state-api-usage
branch
from
c56d8d8 to
37ebe2e
Compare
MingweiSamuel
added a commit
that referenced
this pull request
May 1, 2026
Replace `RefCell<T>` with plain `let mut` local variables for singleton state in DFIR operator codegen. Since subgraphs run sequentially in topological order and singleton references create ordering edges, there is never concurrent access — the RefCell runtime borrow checking was unnecessary overhead. Updated 16 files: process_singletons.rs, meta_graph.rs, 13 operator codegen files (fold, fold_keyed, fold_no_replay, reduce, reduce_keyed, reduce_no_replay, scan, scan_async_blocking, state_by, persist, prefix, repeat_n), lattice_bimorphism operator, and LatticeBimorphismPull runtime. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2829
MingweiSamuel
force-pushed
the
mingwei/delete-state-api-usage
branch
from
37ebe2e to
af90c89
Compare
MingweiSamuel
force-pushed
the
mingwei/singleton-refs-dfir
branch
from
87a6b4f to
5a31e0c
Compare
MingweiSamuel
added a commit
that referenced
this pull request
May 1, 2026
Replace `RefCell<T>` with plain `let mut` local variables for singleton state in DFIR operator codegen. Since subgraphs run sequentially in topological order and singleton references create ordering edges, there is never concurrent access — the RefCell runtime borrow checking was unnecessary overhead. Updated 16 files: process_singletons.rs, meta_graph.rs, 13 operator codegen files (fold, fold_keyed, fold_no_replay, reduce, reduce_keyed, reduce_no_replay, scan, scan_async_blocking, state_by, persist, prefix, repeat_n), lattice_bimorphism operator, and LatticeBimorphismPull runtime. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2829
MingweiSamuel
force-pushed
the
mingwei/singleton-refs-dfir
branch
from
5a31e0c to
2f4bc58
Compare
MingweiSamuel
force-pushed
the
mingwei/delete-state-api-usage
branch
from
af90c89 to
094abd4
Compare
MingweiSamuel
added a commit
that referenced
this pull request
May 1, 2026
Replace `RefCell<T>` with plain `let mut` local variables for singleton state in DFIR operator codegen. Since subgraphs run sequentially in topological order and singleton references create ordering edges, there is never concurrent access — the RefCell runtime borrow checking was unnecessary overhead. Updated 16 files: process_singletons.rs, meta_graph.rs, 13 operator codegen files (fold, fold_keyed, fold_no_replay, reduce, reduce_keyed, reduce_no_replay, scan, scan_async_blocking, state_by, persist, prefix, repeat_n), lattice_bimorphism operator, and LatticeBimorphismPull runtime. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2829
MingweiSamuel
force-pushed
the
mingwei/singleton-refs-dfir
branch
from
2f4bc58 to
339c46f
Compare
Replace `RefCell<T>` with plain `let mut` local variables for singleton state in DFIR operator codegen. Since subgraphs run sequentially in topological order and singleton references create ordering edges, there is never concurrent access — the RefCell runtime borrow checking was unnecessary overhead. Updated 16 files: process_singletons.rs, meta_graph.rs, 13 operator codegen files (fold, fold_keyed, fold_no_replay, reduce, reduce_keyed, reduce_no_replay, scan, scan_async_blocking, state_by, persist, prefix, repeat_n), lattice_bimorphism operator, and LatticeBimorphismPull runtime. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2829
MingweiSamuel
force-pushed
the
mingwei/singleton-refs-dfir
branch
from
339c46f to
f959a3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.