Skip to content

Fix C headers archive for picolibc#1438

Merged
jprendes merged 1 commit intohyperlight-dev:mainfrom
jprendes:fix-ci
May 6, 2026
Merged

Fix C headers archive for picolibc#1438
jprendes merged 1 commit intohyperlight-dev:mainfrom
jprendes:fix-ci

Conversation

@jprendes
Copy link
Copy Markdown
Contributor

@jprendes jprendes commented May 6, 2026

This PR updates the tar-headers recipe in the Justfile to account for the picolibc changes

Copy link
Copy Markdown
Member

@andreiltd andreiltd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remind me why do we copy headers from target dir?

@jprendes
Copy link
Copy Markdown
Contributor Author

jprendes commented May 6, 2026

We used to copy the files from different places in the src dir but we already do that when we build the sysroot, I thought it would be easier to copy them from the sysroot directly.
cargo-hyperlight builds the sysroot in the target dir.

@jprendes
Copy link
Copy Markdown
Contributor Author

jprendes commented May 6, 2026

As to why we do this, it's so that we can publish the sysroot in our release, so that people doing C development doesn't need to install Rust.

We publish 2 .tar.gz archives:

  • hyperlight-guest-c-api-linux.tar.gz: contains the debug and the release version of hyperlight-guest-capi (and all its dependencies)
  • include.tar.gz: contains the libc headers, plus 2 headers generated by cbindgen for hyperlight-guest-capi.

Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
@jprendes jprendes enabled auto-merge (squash) May 6, 2026 17:08
@jprendes jprendes merged commit 4d2896b into hyperlight-dev:main May 6, 2026
49 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bugfix For PRs that fix bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants