Skip to content

Fix: min-key lpy set ordering #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prairir wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: min-key lpy set ordering #857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/clojure/core_test/min_key.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,12 @@
"x" identity ["y" "x" "z"]
[1] identity [[1] [2]]
[1] identity [[2] [1] [3]]
;; set comparison returns first value
#{1} identity [#{1} #{2}]
#{2} identity [#{2} #{1} #{3}]]
Copy link
Copy Markdown
Collaborator

@E-A-Griffin E-A-Griffin Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not introduced by you but these tests don't fit the testing string, might be a good idea to just move these while you're here but don't want to give you extra work

Copy link
Copy Markdown
Contributor Author

@prairir prairir Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote the original tests so I'm happy to move them. Though I'm not certain what you mean 😅. Should I make a set testing section or rename the section?

Copy link
Copy Markdown
Member

@jeaye jeaye Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that Emma was saying this doesn't quite fit under "testing multiple types", so a new section would be ideal. This is a nit, though, so not a blocker for this PR.

Copy link
Copy Markdown
Contributor Author

@prairir prairir Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh understood. I should change the name to complex data types or something. Sorry I haven't gotten around to it. I've had a few family emergencies in the past week.

Copy link
Copy Markdown
Member

@jeaye jeaye Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, my dude. Thank you for all of the help and the responsiveness when it comes to reporting issues and fixing them. That's all we can hope for. I hope that everything's ok on your end. Take whatever time you need; there's no urgency with this.

Copy link
Copy Markdown
Collaborator

@E-A-Griffin E-A-Griffin Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! Sorry for the late response but not a blocker and my point was what @jeaye said

#{2} identity [#{2} #{1}]
#{1} identity [#{1} #{2} #{3}]
#{2} identity [#{2} #{3} #{1}]
#{3} identity [#{3} #{2} #{1}]]
:cljs
["x" identity ["x" "y"]
"x" identity ["y" "x" "z"]
Expand Down
Loading