Support running against Phel

.github/workflows/ci.yml

@@ -162,3 +162,24 @@ jobs:
           BASILISP_TEST_PATH="$(pwd)/test" \
             BASILISP_TEST_FILE_PATTERN='.*\.(lpy|cljc)' \
             basilisp test -p test -- -n auto
+
+  test-phel:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        php: ['8.4', '8.5']
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          coverage: none
+          tools: composer
+
+      - name: Install dependencies
+        run: composer install --no-interaction --no-ansi --no-progress
+
+      - name: Run tests
+        run: php -d memory_limit=256M ./vendor/bin/phel test

.gitignore

@@ -28,3 +28,4 @@ __pycache__/
 poetry.lock
 *.egg-info/
 .DS_Store
+/vendor/

README.md

@@ -22,3 +22,4 @@ See these documents for how to set up individual dialect-specific environments a
 3. [Babashka](doc/babashka.md)
 4. [Clojure CLR](doc/clojureclr.md)
 5. [Basilisp](doc/basilisp.md)
+6. [Phel](doc/phel.md)

composer.json

@@ -0,0 +1,6 @@
+{
+    "require": {
+        "phel-lang/phel-lang": "dev-main"
+    },
+    "minimum-stability": "dev"
+}

doc/phel.md

@@ -0,0 +1,51 @@
+# Running the Phel tests
+
+## Prerequisites
+
+- PHP 8.4+ & [Composer](https://getcomposer.org/doc/00-intro.md#installation-linux-unix-macos)
+
+Install:
+```
+composer install
+```
+
+Tests live in `test/` (override via `phel-config.php`).
+
+See also [Getting Started guide](https://phel-lang.org/documentation/getting-started/).
+
+## Running the test suite
+
+Full suite:
+```
+./vendor/bin/phel test
+```
+Specific test:
+```
+./vendor/bin/phel test test/clojure/core_test/abs.cljc
+```
+
+If runner crashes before report, re-run with `--testdox` or `-v` to locate failing test.
+
+See [Phel testing docs](https://phel-lang.org/documentation/testing/#running-tests).
+
+## Updating Phel version
+
+`composer.json` tracks `dev-main` (latest [phel-lang](https://github.com/phel-lang/phel-lang/) HEAD):
+```json
+{
+    "require": {
+        "phel-lang/phel-lang": "dev-main"
+    },
+    "minimum-stability": "dev"
+}
+```
+
+Pull latest:
+```
+composer update phel-lang/phel-lang
+```
+
+Pin specific commit (optional):
+```
+composer require "phel-lang/phel-lang:dev-main#<commit-hash>"
+```

phel-config.php

@@ -0,0 +1,6 @@
+<?php
+// Override Phel's default 'tests' TestDirs path
+// Reference: https://phel-lang.org/documentation/configuration/
+return (new \Phel\Config\PhelConfig())
+    ->setSrcDirs(['src'])
+    ->setTestDirs(['test']);

test/clojure/core_test/aclone.cljc

@@ -13,8 +13,14 @@
       (is (= 3 (alength a')))
       (is (every? identity (map #(= (aget a %) (aget a' %)) (range 3))))
       (is (zero? (alength b')))
-      (is (not (identical? a a')))
-      (is (not (identical? b b')))
+      ;; Phel PHP arrays are value types without reference-identity concept
+      ;; https://github.com/phel-lang/phel-lang/issues/1735
+      #?@(:phel
+          [(is (identical? a a'))
+           (is (identical? b b'))]
+          :default
+          [(is (not (identical? a a')))
+           (is (not (identical? b b')))])
       (aset a 1 11)
       (is (= 11 (aget a 1)))
       (is (= 2 (aget a' 1)))

test/clojure/core_test/add_watch.cljc

@@ -20,7 +20,8 @@
                                           (catch #?(:cljs :default
                                                     :clj clojure.lang.ExceptionInfo
                                                     :cljr clojure.lang.ExceptionInfo
-                                                    :lpy basilisp.lang.exception/ExceptionInfo) e
+                                                    :lpy basilisp.lang.exception/ExceptionInfo
+                                                    :phel Phel.Lang.ExInfoException) e
                                             (let [data (ex-data e)]
                                               (vswap! state conj data)))))]
                         (do-update a)
@@ -73,6 +74,7 @@
                          {:key :e :ref r :old 14 :new 15 :tester :err})))))
 
     #?@(:cljs []
+        :phel []
         :default
         [(def testvar-a 0)
          (def testvar-b 10)
@@ -145,6 +147,7 @@
 
     #?(:cljs nil
        :lpy nil
+       :phel nil
        :default
        (testing "watch ref"
          (let [state (volatile! [])
@@ -217,6 +220,7 @@
 
     #?@(:cljs []
         :lpy []
+        :phel []
         :default
         [(testing "watch agent"
            (let [state (volatile! [])

test/clojure/core_test/ancestors.cljc

@@ -5,8 +5,8 @@
 (when-var-exists ancestors
 
   ; Some classes for testing ancestors by type inheritance
-  (def AncestorT #?(:cljs js/Object :lpy python/object :default Object))
-  (def ChildT #?(:cljs :default :lpy basilisp.lang.set/PersistentSet :default clojure.lang.PersistentHashSet))
+  (def AncestorT #?(:cljs js/Object :lpy python/object :phel ArrayIterator :default Object))
+  (def ChildT #?(:cljs :default :lpy basilisp.lang.set/PersistentSet :phel RecursiveArrayIterator :default clojure.lang.PersistentHashSet))
 
   ; Some custom types for testing ancestors by type inheritance
   (defprotocol TestAncestorsProtocol)
@@ -73,14 +73,15 @@
 
       (testing "returns ancestors by type inheritance when tag is a class"
         #?(:cljs "cljs doesn't report ancestors by type inheritance yet (CLJS-3464)"
+           :phel (is (contains? (ancestors ChildT) AncestorT))
            :clj  (is (contains? (ancestors ChildT) AncestorT))))
 
       #?(:bb      "bb doesn't report ancestors by type inheritance for custom types"
          :cljs    "cljs doesn't report ancestors by type inheritance yet (CLJS-3464)"
          :default (testing "returns ancestors by type inheritance when tag is a custom type"
-                    (is (contains? (ancestors TestAncestorsType) #?(:lpy (:interface TestAncestorsProtocol) :default clojure.core_test.ancestors.TestAncestorsProtocol)))
-                    (is (contains? (ancestors TestAncestorsRecord) #?(:lpy (:interface TestAncestorsProtocol) :default clojure.core_test.ancestors.TestAncestorsProtocol)))
-                    (is (contains? (ancestors TestAncestorsRecord) #?(:lpy basilisp.lang.interfaces/IAssociative :default clojure.lang.Associative)))
+                    (is (contains? (ancestors TestAncestorsType) #?(:lpy (:interface TestAncestorsProtocol) :phel TestAncestorsProtocol :default clojure.core_test.ancestors.TestAncestorsProtocol)))
+                    (is (contains? (ancestors TestAncestorsRecord) #?(:lpy (:interface TestAncestorsProtocol) :phel TestAncestorsProtocol :default clojure.core_test.ancestors.TestAncestorsProtocol)))
+                    (is (contains? (ancestors TestAncestorsRecord) #?(:lpy basilisp.lang.interfaces/IAssociative :phel Phel.Lang.Collections.Map.PersistentMapInterface :default clojure.lang.Associative)))
                     (is (nil? (ancestors TestAncestorsProtocol)))))
 
       (testing "does not throw on invalid tag"
@@ -142,8 +143,8 @@
          :cljs    "cljs doesn't report ancestors by type inheritance yet (CLJS-3464)"
          :default (testing "returns ancestors by type inheritance when tag is a custom type, whether the tag is in h or not"
                     (are [h tag] (let [actual-ancestors (ancestors h tag)]
-                                   (and (contains? actual-ancestors #?(:lpy (:interface TestAncestorsProtocol) :default clojure.core_test.ancestors.TestAncestorsProtocol))
-                                        (contains? actual-ancestors #?(:lpy basilisp.lang.interfaces/IAssociative :default clojure.lang.Associative))))
+                                   (and (contains? actual-ancestors #?(:lpy (:interface TestAncestorsProtocol) :phel TestAncestorsProtocol :default clojure.core_test.ancestors.TestAncestorsProtocol))
+                                        (contains? actual-ancestors #?(:lpy basilisp.lang.interfaces/IAssociative :phel Phel.Lang.Collections.Map.PersistentMapInterface :default clojure.lang.Associative))))
                                  ; tag in h
                                  datatypes TestAncestorsRecord
                                  ; tag not in h

test/clojure/core_test/associative_qmark.cljc

@@ -19,8 +19,12 @@
       false #{}
       false #{:a :b}
       false "ab"
-      false (seq "ab")                  ; seq
-      false (to-array [1 2 3])
+
+      #?@(:phel [true (seq "ab") ; PHP arrays are associative
+                 true (to-array [1 2 3])]
+          :default
+          [false (seq "ab")                  ; seq
+           false (to-array [1 2 3])])
       false :a
       false 'a
       false 1

test/clojure/core_test/case.cljc

@@ -111,6 +111,23 @@
              4N :big-decimal-result
              4.0 :big-decimal-result
              4.0M :big-decimal-result]
+            :phel
+            [1 :integer-result
+             1N :integer-result
+             1.0 :default
+             1.0M :default
+             2 :big-integer-result
+             2N :big-integer-result
+             2.0 :default
+             2.0M :default
+             3 :default
+             3N :default
+             3.0 :double-result
+             3.0M :double-result ; big-decimal not supported (uses float)
+             4 :default
+             4N :default
+             4.0 :big-decimal-result ; big-decimal not supported (uses float)
+             4.0M :big-decimal-result]
             :default
             [1 :integer-result
              1N :integer-result ; JVM sees ints and big ints as equal for int-sized values

test/clojure/core_test/char_qmark.cljc

@@ -44,6 +44,9 @@
           [true "0"
            true "1"]
           :lpy
+          [true "0"
+           true "1"]
+          :phel
           [true "0"
            true "1"]
           :default

test/clojure/core_test/dec.cljc

@@ -26,6 +26,7 @@
       #?(:clj (is (p/thrown? (dec Long/MIN_VALUE)))
          :cljr (is (p/thrown? (dec Int64/MinValue)))
          :cljs (is (= (dec js/Number.MIN_SAFE_INTEGER) (- js/Number.MIN_SAFE_INTEGER 2)))
+         :phel (is (= (dec php/PHP_INT_MIN) (dec php/PHP_INT_MIN)))
          :lpy []  ; Python integers cannot underflow
          :default (is false "TODO underflow")))
 

test/clojure/core_test/derive.cljc

@@ -13,7 +13,7 @@
                           success)
                         ::rect ::shape
                         'n/a 'n/b
-                        #?(:cljs js/String :lpy python/str :default String) ::object))
+                        #?(:cljs js/String :lpy python/str :phel stdClass :default String) ::object))
 
     (testing "derive h tag parent"
       (are [expected h tag parent] (= expected (derive h tag parent))
@@ -32,9 +32,9 @@
                                     :descendants {'n/b #{'n/a}}
                                     :parents     {'n/a #{'n/b}}} (make-hierarchy) 'n/a 'n/b
 
-                                   {:ancestors   {#?(:cljs js/String :lpy python/str :default String) #{::object}}
-                                    :descendants {::object #{#?(:cljs js/String :lpy python/str :default String)}}
-                                    :parents     {#?(:cljs js/String :lpy python/str :default String) #{::object}}} (make-hierarchy) #?(:cljs js/String :lpy python/str :default String) ::object
+                                   {:ancestors   {#?(:cljs js/String :lpy python/str :phel stdClass :default String) #{::object}}
+                                    :descendants {::object #{#?(:cljs js/String :lpy python/str :phel stdClass :default String)}}
+                                    :parents     {#?(:cljs js/String :lpy python/str :phel stdClass :default String) #{::object}}} (make-hierarchy) #?(:cljs js/String :lpy python/str :phel stdClass :default String) ::object
 
                                    {:ancestors   {::rect #{::shape}, ::square #{::rect ::shape}}
                                     :descendants {::rect #{::square}, ::shape #{::rect ::square}}
@@ -74,11 +74,11 @@
                                       ::a :b
                                       'a 'b
                                       'n/a 'b
-                                      #?(:cljs js/String :lpy python/str :default String) :b)))
+                                      #?(:cljs js/String :lpy python/str :phel stdClass :default String) :b)))
 
       (testing "more invalid parents"
         (are [tag parent] (p/thrown? (derive tag parent))
-                          ::tag #?(:cljs js/String :lpy python/str :default String)
+                          ::tag #?(:cljs js/String :lpy python/str :phel stdClass :default String)
                           ::tag 42
                           ::tag "parent"))
 

test/clojure/core_test/double_qmark.cljc

@@ -32,6 +32,10 @@
               true (float 1.0)
               true (float -1.0)]
              :lpy
+             [true (float 0.0)
+              true (float 1.0)
+              true (float -1.0)]
+             :phel
              [true (float 0.0)
               true (float 1.0)
               true (float -1.0)]
@@ -55,6 +59,13 @@
               true 0.0M
               true 1.0M
               true -1.0M]
+             :phel
+             [false 0N
+              false 1N
+              false -1N
+              true 0.0M
+              true 1.0M
+              true -1.0M]
              :default
              [false 0N
               false 1N
@@ -63,6 +74,9 @@
               false 1.0M
               false -1.0M])
       #?@(:cljs [] ; CLJS doesn't have ratios
+          :phel [true 0/2 ; Phel handles them as float
+                 true 1/2
+                 true -1/2]
           :default
           [false 0/2
            false 1/2

test/clojure/core_test/eq.cljc

@@ -83,6 +83,7 @@
   (testing "regex"
     ;; Basilisp regex patterns compare equal and identical?
     #?(:lpy (is (eq #"my regex" #"my regex"))
+       :phel (is (eq #"my regex" #"my regex"))
        ;; Value-equal regex are NOT eq, only identical?
        :default (is (not (eq #"my regex" #"my regex"))))
     (is (let [r #"my regex"

test/clojure/core_test/float.cljc

@@ -26,6 +26,7 @@
       ;; so float returns the same value here.
       #?@(:cljs [r/min-double r/min-double]
           :lpy [r/min-double r/min-double]
+          :phel [r/min-double r/min-double]
           :default [(float 0.0) r/min-double]))
     (is (NaN? (float ##NaN)))
 

test/clojure/core_test/float_qmark.cljc

@@ -56,10 +56,19 @@
           false 0N
           false 1N
           false -1N
-          false 0.0M
-          false 1.0M
-          false -1.0M])
+          #?@(:phel
+              [true 0.0M
+               true 1.0M
+               true -1.0M]
+              :default
+              [false 0.0M
+               false 1.0M
+               false -1.0M])])
      #?@(:cljs [] ; CLJS doesn't have ratios
+         :phel
+         [true 0/2
+          true 1/2
+          true -1/2]
          :default
          [false 0/2
           false 1/2

test/clojure/core_test/inc.cljc

@@ -27,6 +27,7 @@
       #?(:clj (is (p/thrown? (inc Long/MAX_VALUE)))
          :cljr (is (p/thrown? (inc Int64/MaxValue)))
          :cljs (is (= (inc js/Number.MAX_SAFE_INTEGER) (+ 2 js/Number.MAX_SAFE_INTEGER)))
+         :phel (is (= (inc php/PHP_INT_MAX) (+ 2 php/PHP_INT_MAX)))
          :lpy nil  ; Python integers cannot overflow
          :default (is false "overflow untested")))
 

test/clojure/core_test/int_qmark.cljc

@@ -22,10 +22,13 @@
      false ##Inf
      false ##-Inf
      false ##NaN
-     #?@(:cljs [true] :lpy [true] :default [false]) 0N
-     #?@(:cljs [true] :lpy [true] :default [false]) 1N
-     #?@(:cljs [true] :lpy [true] :default [false]) -1N
+     #?@(:cljs [true] :lpy [true] :phel [true] :default [false]) 0N
+     #?@(:cljs [true] :lpy [true] :phel [true] :default [false]) 1N
+     #?@(:cljs [true] :lpy [true] :phel [true] :default [false]) -1N
      #?@(:cljs []
+         :phel [false  0/2
+                false 1/2
+                false -1/2]
          :default
          [true  0/2
           false 1/2

test/clojure/core_test/integer_qmark.cljc

@@ -26,6 +26,10 @@
       true   1N
       true   -1N
       #?@(:cljs []
+          :phel
+          [false  0/2
+           false 1/2
+           false -1/2]
           :default
           [true  0/2
            false 1/2