Skip to content

Make it possible to override chart repository in a particular pipeline#1050

Draft
msvticket wants to merge 1 commit intomainfrom
override-chart-repository
Draft

Make it possible to override chart repository in a particular pipeline#1050
msvticket wants to merge 1 commit intomainfrom
override-chart-repository

Conversation

@msvticket
Copy link
Copy Markdown
Contributor

@msvticket msvticket commented Mar 16, 2026

Testing a new helm registry is cumbersome since the setting in jx-requirements.yaml overrides JX_CHART_REPOSITORY. Also it is impossible to test the default values, like automatically using the .Cluster.Registry for OCI. This PR fixes these issues.

@jenkins-x-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign msvticket
You can assign the PR to them by writing /assign @msvticket in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msvticket msvticket force-pushed the override-chart-repository branch from d976aa5 to b2937de Compare March 16, 2026 20:27
…peline

this includes override with the empty string to get a default value
@msvticket msvticket force-pushed the override-chart-repository branch from b2937de to 558f389 Compare March 16, 2026 21:54
@msvticket
Copy link
Copy Markdown
Contributor Author

/retest

@msvticket
Copy link
Copy Markdown
Contributor Author

/cc tomhobson JordanGoasdoue Skisocks mentlak0

@msvticket msvticket marked this pull request as draft March 17, 2026 09:44
@msvticket
Copy link
Copy Markdown
Contributor Author

I realised that the new implementation of FindRepositoryURL won't play nice with jx promote. So I need think this through another round.

@msvticket msvticket force-pushed the override-chart-repository branch from 558f389 to 39701a5 Compare March 17, 2026 10:26
@msvticket msvticket changed the title OCI helm registry fixes Make it possible to override chart repository in a particular pipeline Mar 17, 2026
@msvticket
Copy link
Copy Markdown
Contributor Author

I split out the non-problematic part to a separate PR #1051

@Skisocks
Copy link
Copy Markdown
Member

@msvticket is this still required? Still in draft so not sure if you want it reviewing :)

@msvticket
Copy link
Copy Markdown
Contributor Author

I think there is a need, but the change would require changes in jx promote as well. And I'm not sure it is worth the effort... No, I don't expect reviews on draft unless I ask for it explicitly. I should have removed you as reviewer when switching this to draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants