Make it possible to override chart repository in a particular pipeline#1050
Make it possible to override chart repository in a particular pipeline#1050
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
d976aa5 to
b2937de
Compare
…peline this includes override with the empty string to get a default value
b2937de to
558f389
Compare
|
/retest |
|
/cc tomhobson JordanGoasdoue Skisocks mentlak0 |
|
I realised that the new implementation of FindRepositoryURL won't play nice with jx promote. So I need think this through another round. |
558f389 to
39701a5
Compare
|
I split out the non-problematic part to a separate PR #1051 |
|
@msvticket is this still required? Still in draft so not sure if you want it reviewing :) |
|
I think there is a need, but the change would require changes in jx promote as well. And I'm not sure it is worth the effort... No, I don't expect reviews on draft unless I ask for it explicitly. I should have removed you as reviewer when switching this to draft. |
Testing a new helm registry is cumbersome since the setting in jx-requirements.yaml overrides JX_CHART_REPOSITORY. Also it is impossible to test the default values, like automatically using the .Cluster.Registry for OCI. This PR fixes these issues.