feat: expose merge_commit_template to gitops scheduler#1070
Open
Skisocks wants to merge 2 commits intojenkins-x-plugins:mainfrom
Open
feat: expose merge_commit_template to gitops scheduler#1070Skisocks wants to merge 2 commits intojenkins-x-plugins:mainfrom
Skisocks wants to merge 2 commits intojenkins-x-plugins:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/cc @msvticket |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
merge_commit_templateto scheduler config so github default can be overridenContext
We use the
merge_method: squashfor all our repositories. This work fine aside from github incorrectly inferring a link to the wrong PR in our cluster repos.deps: update service docker tag to v1.0.0 (#535)Problem is the #535 in the context of the cluster repo actually points to PR 535 in the cluster repo rather than the app repo.
We'd like to overwrite the default merge commit message at the scheduler level so that the references are correct e.g.: