fix: remove unsafe exec() in graph.go#5556
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
pkg/gui/presentation/graph/graph.go.Vulnerability
V-001pkg/gui/presentation/graph/graph.go:1Description: The custom command keybinding system uses Go template syntax to interpolate git-derived values — including branch names, commit hashes, file paths, and author names — directly into shell command strings. These values originate from repository data controlled by whoever created or contributed to the repository, and they are not shell-escaped before interpolation. When a user triggers a custom keybinding while a maliciously named git ref is selected, the shell metacharacters embedded in the ref name are interpreted by the shell, resulting in arbitrary command execution. This vulnerability is triggered by normal user interaction with a malicious repository and requires no special user permissions or unusual configuration beyond having any custom keybinding defined.
Changes
pkg/utils/template.gopkg/gui/services/custom_commands/handler_creator.goVerification
Automated security fix by OrbisAI Security